include env key in error and logs when value is too large (#159)

* include env key in error and logs when value is too large * code review fix: consistent log formatting
bitrise-io · Feb 7, 2019 · a9fc969 · a9fc969
1 parent 41ea1b6
commit a9fc969
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/cli/add.go b/cli/add.go
@@ -2,6 +2,7 @@ package cli
 
 import (
 	"errors"
+	"fmt"
 	"io/ioutil"
 	"os"
 
@@ -40,9 +41,9 @@ func validateEnv(key, value string, envList []models.EnvironmentItemModel) (stri
 	if configs.EnvBytesLimitInKB > 0 {
 		if valueSizeInBytes > configs.EnvBytesLimitInKB*1024 {
 			valueSizeInKB := ((float64)(valueSizeInBytes)) / 1024.0
-			log.Warnf("environment value (%s...) too large", value[0:100])
+			log.Warnf("environment var (%s) value (%s...) too large", key, value[0:100])
 			log.Warnf("environment value size (%#v KB) - max allowed size: %#v KB", valueSizeInKB, (float64)(configs.EnvBytesLimitInKB))
-			return "environment value too large - rejected", nil
+			return fmt.Sprintf("environment var (%s) value too large - rejected", key), nil
 		}
 	}
 

diff --git a/cli/add_test.go b/cli/add_test.go
@@ -72,5 +72,5 @@ func TestValidateEnv(t *testing.T) {
 
 	valValue, err = validateEnv("key", str21Kbytes, envs)
 	require.NoError(t, err)
-	require.Equal(t, "environment value too large - rejected", valValue)
+	require.Equal(t, "environment var (key) value too large - rejected", valValue)
 }