Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: bitcoin/bitcoin
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: bitpay/bitcoin
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.12.1-bitcore
Choose a head ref
Can’t automatically merge. Don’t worry, you can still create the pull request.

Commits on Dec 3, 2015

  1. Bump version to 0.12.0

    Bump version from 0.11.99 to 0.12.0 so that we don't forget to do this
    when rc1 is released.
    laanwj committed Dec 3, 2015
    Copy the full SHA
    2985000 View commit details
  2. Add missing automake package to deb-based UNIX install instructions.

    Rebased-From: b440409
    Github-Pull: #7152
    posita authored and laanwj committed Dec 3, 2015
    Copy the full SHA
    cfb44ce View commit details

Commits on Dec 4, 2015

  1. Disconnect on mempool requests from peers when over the upload limit.

    Mempool requests use a fair amount of bandwidth when the mempool is large,
     disconnecting peers using them follows the same logic as disconnecting
     peers fetching historical blocks.
    
    Rebased-From: 6aadc75
    Github-Pull: #7166
    gmaxwell authored and laanwj committed Dec 4, 2015
    Copy the full SHA
    6ba25d2 View commit details
  2. Copy the full SHA
    f31955d View commit details

Commits on Dec 7, 2015

  1. Don't do mempool lookups for "mempool" command without a filter

    Github-Pull: #7174
    Rebased-From: 96918a2
    TheBlueMatt authored and laanwj committed Dec 7, 2015
    Copy the full SHA
    82aff88 View commit details
  2. test: remove necessity to call create_callback_map

    Remove necessity to call create_callback_map (as well as the function
    itself) from the Python P2P test framework. Invoke the appropriate
    methods directly.
    
    - Easy to forget to call it and wonder why it doesn't work
    - Simplifies the code
    - This makes it easier to handle new messages in subclasses
    
    Github-Pull: #7171
    Rebased-From: 2f601d2
    laanwj committed Dec 7, 2015
    Copy the full SHA
    b2d7ada View commit details

Commits on Dec 8, 2015

  1. Coinselection prunes extraneous inputs from ApproximateBestSubset

    This is a combination of 3 commits.
    
    - Coinselection prunes extraneous inputs from ApproximateBestSubset
      A further pass over the available inputs has been added to ApproximateBestSubset after a candidate set has been found. It will prune any extraneous inputs in the selected subset, in order to decrease the number of input and the resulting change.
    - Moved set reduction to the end of ApproximateBestSubset to reduce performance impact
    - Added a test for the pruning of extraneous inputs after ApproximateBestSet
    
    Github-Pull: #4906
    Rebased-From: 5c03483 af9510e fc0f52d
    murchandamus authored and laanwj committed Dec 8, 2015
    1
    Copy the full SHA
    96e8d12 View commit details

Commits on Dec 10, 2015

  1. net: Fix sent reject messages for blocks and transactions

    Ever since we #5913 have been sending invalid reject messages
    for transactions and blocks.
    
    test: Add basic test for `reject` code
    
    Extend P2P test framework to make it possible to expect reject
    codes for transactions and blocks.
    
    Github-Pull: #7179
    Rebased-From: 9fc6ed6 2041190
    laanwj committed Dec 10, 2015
    Copy the full SHA
    44fef99 View commit details

Commits on Dec 11, 2015

  1. net: Add and document network messages in protocol.h

    - Avoids string typos (by making the compiler check)
    - Makes it easier to grep for handling/generation of a certain message type
    - Refer directly to documentation by following the symbol in IDE
    - Move list of valid message types to protocol.cpp:
        protocol.cpp is a more appropriate place for this, and having
        the array there makes it easier to keep things consistent.
    
    Github-Pull: #7181
    Rebased-From: 9bbe71b
    laanwj committed Dec 11, 2015
    Copy the full SHA
    8fc174a View commit details

Commits on Dec 14, 2015

  1. Add "NODE_BLOOM" to guiutil so that peers don't get UNKNOWN[4]

    Rebased-From: daf6466
    Github-Pull: #7206
    TheBlueMatt authored and laanwj committed Dec 14, 2015
    Copy the full SHA
    f43c2f9 View commit details
  2. Checks for null data transaction before issuing error to debug.log

    CWalletTx::GetAmounts could not find output address for null data transactions, thus issuing an error in debug.log. This change checks to see if the transaction is OP_RETURN before issuing error.
    
    resolves #6142
    
    Github-Pull: #7200
    Rebased-From: b6915b8 c611acc d812daf
    accraze authored and laanwj committed Dec 14, 2015
    Copy the full SHA
    06c6a58 View commit details
  3. Replace trickle nodes with per-node/message Poisson delays

    We used to have a trickle node, a node which was chosen in each iteration of
    the send loop that was privileged and allowed to send out queued up non-time
    critical messages. Since the removal of the fixed sleeps in the network code,
    this resulted in fast and attackable treatment of such broadcasts.
    
    This pull request changes the 3 remaining trickle use cases by random delays:
    * Local address broadcast (while also removing the the wiping of the seen filter)
    * Address relay
    * Inv relay (for transactions; blocks are always relayed immediately)
    
    The code is based on older commits by Patrick Strateman.
    
    Github-Pull: #7125
    Rebased-From: 5400ef6
    sipa authored and laanwj committed Dec 14, 2015
    Copy the full SHA
    10b88be View commit details

Commits on Dec 17, 2015

  1. Removed offline testnet DNSSeed 'alexykot.me'.

    Github-Pull: #7216
    Rebased-From: e18378e
    Elias Rohrer authored and laanwj committed Dec 17, 2015
    Copy the full SHA
    9572e49 View commit details
  2. test: don't override BITCOIND and BITCOINCLI if they're set

    In rpc-tests.py, don't override BITCOIND and BITCOINCLI if they're
    already set. Makes it possible to run the tests with either another tree
    or the GUI.
    
    Github-Pull: #7209
    Rebased-From: 83cdcbd
    laanwj committed Dec 17, 2015
    Copy the full SHA
    f3ad812 View commit details

Commits on Dec 18, 2015

  1. [Depends] Bump Boost, miniupnpc, ccache & zeromq

    Bring dependencies up to date with master:
    [depends] Boost 1.59.0
    [depends] miniupnpc 1.9.20151026
    [depends] native ccache 3.2.4
    [depends] zeromq 4.0.7
    [depends] Latest config.guess & config.sub
    [depends] Fix miniupnpc compilation on osx
    
    Github-Pull: #6980
    Rebased-From: 9e940fa 17ad964 26f8ea5 10d3c77 23a3c47 e0769e1
    fanquake authored and laanwj committed Dec 18, 2015
    Copy the full SHA
    eccd671 View commit details

Commits on Dec 21, 2015

  1. [Mempool] Fix mempool limiting and replace-by-fee for PrioritiseTrans…

    …action
    
    1) Fix mempool limiting for PrioritiseTransaction
    
    Redo the feerate index to be based on mining score, rather than fee.
    
    Update mempool_packages.py to test prioritisetransaction's effect on
    package scores.
    
    2) Update replace-by-fee logic to use fee deltas
    
    3) Use fee deltas for determining mempool acceptance
    
    4) Remove GetMinRelayFee
    
    One test in AcceptToMemoryPool was to compare a transaction's fee
    agains the value returned by GetMinRelayFee. This value was zero for
    all small transactions.  For larger transactions (between
    DEFAULT_BLOCK_PRIORITY_SIZE and MAX_STANDARD_TX_SIZE), this function
    was preventing low fee transactions from ever being accepted.
    
    With this function removed, we will now allow transactions in that range
    with fees (including modifications via PrioritiseTransaction) below
    the minRelayTxFee, provided that they have sufficient priority.
    
    Github-Pull: #7062
    Rebased-From: eb30666 9ef2a25 27fae34 901b01d
    sdaftuar authored and laanwj committed Dec 21, 2015
    Copy the full SHA
    12c469b View commit details

Commits on Dec 22, 2015

  1. Add more tests to p2p-fullblocktest

    Github-Pull: #7226
    Rebased-From: 9b41a5f
    sdaftuar authored and laanwj committed Dec 22, 2015
    Copy the full SHA
    301f16a View commit details
  2. [Tests] Add mempool_limit.py test

    - [Tests] Add mempool_limit.py test
    - [Tests] Refactor some shared functions
    
    Github-Pull: #7153
    Rebased-From: 110ff11 7632cf6
    jonasschnelli authored and laanwj committed Dec 22, 2015
    Copy the full SHA
    9ef7c54 View commit details
  3. tests: Disable Tor interaction

    This is unnecessary during the current tests (any test for Tor
    interaction can explicitly enable it) and interferes with the proxy
    test.
    
    Github-Pull: #7170
    Rebased-From: 4c40ec0
    laanwj committed Dec 22, 2015
    Copy the full SHA
    453c567 View commit details

Commits on Jan 4, 2016

  1. Report non-mandatory script failures correctly

    Github-Pull: #7276
    Rebased-From: 7ef8f3c
    sipa authored and laanwj committed Jan 4, 2016
    Copy the full SHA
    76de36f View commit details
  2. Merge pull request #7245

    fa8c8d7 torcontrol debug: Change to a blanket message that covers both cases (MarcoFalke)
    laanwj committed Jan 4, 2016
    Copy the full SHA
    2d6a493 View commit details
  3. Copy the full SHA
    5ba42ba View commit details
  4. [debian] Bump manpages and only mention -?

    The manpages are outdated and are very rarely updated when changes
    to the code happen.
    
    Github-Pull: #7274
    Rebased-From: fae7a36 fa6ce44
    MarcoFalke authored and laanwj committed Jan 4, 2016
    Copy the full SHA
    e70fc6f View commit details
  5. [gitian] Set reference date to something more recent

    Github-Pull: #7251
    Rebased-From: fa09562
    MarcoFalke authored and laanwj committed Jan 4, 2016
    Copy the full SHA
    f6c8c12 View commit details
  6. [qa] Move gen_return_txouts() to util.py

    Github-Pull: #7250
    Rebased-From: fa0a974
    MarcoFalke authored and laanwj committed Jan 4, 2016
    Copy the full SHA
    bdd0f9e View commit details
  7. Bugfix: update-translations: Allow numerus translations to omit %n sp…

    …ecifier (usually when it only has one possible value)
    
    Github-Pull: #7253
    Rebased-From: 0d59589
    luke-jr authored and laanwj committed Jan 4, 2016
    Copy the full SHA
    a75a03a View commit details
  8. Update translations after #7253

    Include translations that omit raw number from the singular case.
    laanwj committed Jan 4, 2016
    Copy the full SHA
    3cb066c View commit details

Commits on Jan 5, 2016

  1. Mark blocks with too many sigops as failed

    Github-Pull: #7217
    Rebased-From: 5246180
    sdaftuar authored and laanwj committed Jan 5, 2016
    Copy the full SHA
    e08b7cb View commit details
  2. [wallet] Adjust pruning test

    Github-Pull: #7193
    Rebased-From: fafd093
    MarcoFalke authored and laanwj committed Jan 5, 2016
    Copy the full SHA
    bfdaa3c View commit details
  3. [Qt] fix coincontrol update issue when deleting a send coin entry

    Github-Pull: #7282
    Rebased-From: 621bd69
    jonasschnelli authored and laanwj committed Jan 5, 2016
    Copy the full SHA
    5cadf3e View commit details
  4. Bump copyright headers to 2015

    - Bump copyright headers to 2015
    - [devtools] Rewrite fix-copyright-headers.py
    - [devtools] Use git pretty-format for year parsing
    
    Github-Pull: #7205
    Rebased-From: fa6ad85 fa24439 fa71669
    MarcoFalke authored and laanwj committed Jan 5, 2016
    Copy the full SHA
    333e1ea View commit details

Commits on Jan 7, 2016

  1. [qa] wallet: Check if maintenance changes the balance

    - [qa] Cleanup wallet.py test
    - [qa] check if wallet or blochchain maintenance changes the balance
    - [walletdb] Add missing LOCK() in Recover() for dummyWallet
    
    Github-Pull: #7229
    Rebased-From: fa0765d fa14d99 fa33d97
    MarcoFalke authored and laanwj committed Jan 7, 2016
    Copy the full SHA
    1ed938b View commit details
  2. [wallet] Add regression test for vValue sort order

    - [wallet] Add regression test for vValue sort order
    - [trivial] Merge test cases and replace CENT with COIN
    
    Github-Pull: #7293
    Rebased-From: fa3c7e6 faf538b
    MarcoFalke authored and laanwj committed Jan 7, 2016
    1
    Copy the full SHA
    ff9b610 View commit details
  3. Update release-notes.md

    Transaction memory pool limiting
    
    Priority transactions
    
    Wallet transaction fees
    MarcoFalke committed Jan 7, 2016
    Copy the full SHA
    fabba1c View commit details

Commits on Jan 8, 2016

  1. Copy the full SHA
    daa8da2 View commit details
  2. [qt] Intro: Display required space

    Required space depends on the user's choice:
     -prune=0
     -prune=<n>
    MarcoFalke authored and jonasschnelli committed Jan 8, 2016
    Copy the full SHA
    b1a8374 View commit details
  3. Copy the full SHA
    fa4ba40 View commit details
  4. Merge pull request #7319

    b1a8374 [qt] Intro: Display required space (MarcoFalke)
    laanwj committed Jan 8, 2016
    Copy the full SHA
    1320300 View commit details
  5. Merge pull request #7318

    daa8da2 Backport: quickfix for RPC timer interface problem (Jonas Schnelli)
    laanwj committed Jan 8, 2016
    Copy the full SHA
    9265e89 View commit details
  6. Make sure conflicted wallet tx's update balances

    Github-Pull: #7306
    Rebased-From: f61766b
    morcos authored and laanwj committed Jan 8, 2016
    Copy the full SHA
    4707797 View commit details

Commits on Jan 9, 2016

  1. [Tests] Eliminate intermittent failures in sendheaders.py

    - Add race-condition debugging tool to mininode
    - Eliminate race condition in sendheaders.py test
    
    Clear the last block announcement before mining new blocks.
    
    Github-Pull: #7308
    Rebased-From: 82a0ce0 168915e
    sdaftuar authored and laanwj committed Jan 9, 2016
    Copy the full SHA
    d513405 View commit details
  2. Merge branch bytespersigop

    luke-jr committed Jan 9, 2016
    Copy the full SHA
    5b144b7 View commit details
  3. Merge pull request #7323

    45b8e27 -bytespersigop option to additionally limit sigops in transactions we relay and mine (Luke Dashjr)
    laanwj committed Jan 9, 2016
    Copy the full SHA
    a344880 View commit details

Commits on Jan 13, 2016

  1. Add Replace-by-fee to release-notes

    MarcoFalke committed Jan 13, 2016
    Copy the full SHA
    fa0a391 View commit details
  2. Merge pull request #7324

    laanwj committed Jan 13, 2016
    Copy the full SHA
    8f25d6e View commit details
  3. Add sane fallback for fee estimation

    - Always respect GetRequiredFee for wallet txs
    - Add sane fallback for fee estimation
    - SQUASHME: Fix rpc tests that assumed fallback to minRelayTxFee
    
    Add new commandline option "-fallbackfee" to use when fee estimation does not have sufficient data.
    
    Github-Pull: #7296
    Rebased-From: 995b9f3 e420a1b bebe58b
    morcos authored and laanwj committed Jan 13, 2016
    Copy the full SHA
    a36d79b View commit details
  4. Add fallbackfee default value

    MarcoFalke committed Jan 13, 2016
    Copy the full SHA
    fab88af View commit details
  5. Merge pull request #7309

    fab88af Add fallbackfee default value (MarcoFalke)
    fa0a391 Add Replace-by-fee to release-notes (MarcoFalke)
    fa4ba40 Expand section "Wallet transaction fees" & fix format and typos (MarcoFalke)
    fabba1c Update release-notes.md (MarcoFalke)
    laanwj committed Jan 13, 2016
    Copy the full SHA
    2c5c215 View commit details
  6. Add RPC call abandontransaction

    - Make wallet descendant searching more efficient
    - Add new rpc call: abandontransaction
    
    Unconfirmed transactions that are not in your mempool either due to eviction or other means may be unlikely to be mined.  abandontransaction gives the wallet a way to no longer consider as spent the coins that are inputs to such a transaction.  All dependent transactions in the wallet will also be marked as abandoned.
    
    - Add RPC test for abandoned and conflicted transactions.
    - [Wallet] Call notification signal when a transaction is abandoned
    
    Github-Pull: #7312
    Rebased-From: 9e69717 01e06d1 df0e222 d11fc16
    morcos authored and laanwj committed Jan 13, 2016
    Copy the full SHA
    fd4bd50 View commit details
  7. Copy the full SHA
    071f704 View commit details
Showing 473 changed files with 22,777 additions and 4,219 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -114,3 +114,4 @@ share/BitcoindComparisonTool.jar
/doc/doxygen/

libbitcoinconsensus.pc
wallet-utility
21 changes: 14 additions & 7 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -3,6 +3,11 @@
# compiler key (which we don't use anyway). This is worked around for now by
# replacing the "compilers" with a build name prefixed by the no-op ":"
# command. See: https://github.com/travis-ci/travis-ci/issues/4393
# - sudo/dist/group are set so as to get Blue Box VMs, necessary for [loopback]
# IPv6 support

sudo: required
dist: trusty

os: linux
language: cpp
@@ -31,36 +36,38 @@ matrix:
- compiler: ": ARM"
env: HOST=arm-linux-gnueabihf PACKAGES="g++-arm-linux-gnueabihf" DEP_OPTS="NO_QT=1" GOAL="install" BITCOIN_CONFIG="--enable-glibc-back-compat --enable-reduce-exports"
- compiler: ": Win32"
env: HOST=i686-w64-mingw32 PPA="ppa:ubuntu-wine/ppa" PACKAGES="nsis gcc-mingw-w64-i686 g++-mingw-w64-i686 binutils-mingw-w64-i686 mingw-w64-dev wine1.7 bc" RUN_TESTS=true GOAL="deploy" BITCOIN_CONFIG="--enable-gui --enable-reduce-exports" MAKEJOBS="-j2"
env: HOST=i686-w64-mingw32 DPKG_ADD_ARCH="i386" DEP_OPTS="NO_QT=1" PACKAGES="nsis g++-mingw-w64-i686 wine1.6 bc" RUN_TESTS=true GOAL="install" BITCOIN_CONFIG="--enable-reduce-exports"
- compiler: ": 32-bit + dash"
env: HOST=i686-pc-linux-gnu PACKAGES="g++-multilib bc python-zmq" PPA="ppa:chris-lea/zeromq" RUN_TESTS=true GOAL="install" BITCOIN_CONFIG="--enable-zmq --enable-glibc-back-compat --enable-reduce-exports LDFLAGS=-static-libstdc++" USE_SHELL="/bin/dash"
env: HOST=i686-pc-linux-gnu PACKAGES="g++-multilib bc python-zmq" DEP_OPTS="NO_QT=1" RUN_TESTS=true GOAL="install" BITCOIN_CONFIG="--enable-zmq --enable-glibc-back-compat --enable-reduce-exports LDFLAGS=-static-libstdc++" USE_SHELL="/bin/dash"
- compiler: ": Win64"
env: HOST=x86_64-w64-mingw32 PPA="ppa:ubuntu-wine/ppa" PACKAGES="nsis gcc-mingw-w64-x86-64 g++-mingw-w64-x86-64 binutils-mingw-w64-x86-64 mingw-w64-dev wine1.7 bc" RUN_TESTS=true GOAL="deploy" BITCOIN_CONFIG="--enable-gui --enable-reduce-exports" MAKEJOBS="-j2"
env: HOST=x86_64-w64-mingw32 DPKG_ADD_ARCH="i386" DEP_OPTS="NO_QT=1" PACKAGES="nsis g++-mingw-w64-x86-64 wine1.6 bc" RUN_TESTS=true GOAL="install" BITCOIN_CONFIG="--enable-reduce-exports"
- compiler: ": bitcoind"
env: HOST=x86_64-unknown-linux-gnu PACKAGES="bc python-zmq" PPA="ppa:chris-lea/zeromq" DEP_OPTS="NO_QT=1 NO_UPNP=1 DEBUG=1" RUN_TESTS=true GOAL="install" BITCOIN_CONFIG="--enable-zmq --enable-glibc-back-compat --enable-reduce-exports CPPFLAGS=-DDEBUG_LOCKORDER"
env: HOST=x86_64-unknown-linux-gnu PACKAGES="bc python-zmq" DEP_OPTS="NO_QT=1 NO_UPNP=1 DEBUG=1" RUN_TESTS=true GOAL="install" BITCOIN_CONFIG="--enable-zmq --enable-glibc-back-compat --enable-reduce-exports CPPFLAGS=-DDEBUG_LOCKORDER"
- compiler: ": No wallet"
env: HOST=x86_64-unknown-linux-gnu DEP_OPTS="NO_WALLET=1" RUN_TESTS=true GOAL="install" BITCOIN_CONFIG="--enable-glibc-back-compat --enable-reduce-exports"
- compiler: ": Cross-Mac"
env: HOST=x86_64-apple-darwin11 PACKAGES="cmake libcap-dev libz-dev libbz2-dev" BITCOIN_CONFIG="--enable-reduce-exports" OSX_SDK=10.9 GOAL="deploy"
exclude:
- compiler: gcc
before_install:
- export PATH=$(echo $PATH | tr ':' "\n" | sed '/\/opt\/python/d' | tr "\n" ":" | sed "s|::|:|g")
install:
- if [ -n "$PACKAGES" ]; then sudo rm -f /etc/apt/sources.list.d/travis_ci_zeromq3-source.list; fi
- if [ -n "$PACKAGES" ]; then sudo rm -f /etc/apt/sources.list.d/google-chrome.list; fi
- if [ -n "$PPA" ]; then travis_retry sudo add-apt-repository "$PPA" -y; fi
- if [ -n "$DPKG_ADD_ARCH" ]; then sudo dpkg --add-architecture "$DPKG_ADD_ARCH" ; fi
- if [ -n "$PACKAGES" ]; then travis_retry sudo apt-get update; fi
- if [ -n "$PACKAGES" ]; then travis_retry sudo apt-get install --no-install-recommends --no-upgrade -qq $PACKAGES; fi
before_script:
- unset CC; unset CXX
- mkdir -p depends/SDKs depends/sdk-sources
- if [ -n "$OSX_SDK" -a ! -f depends/sdk-sources/MacOSX${OSX_SDK}.sdk.tar.gz ]; then wget $SDK_URL/MacOSX${OSX_SDK}.sdk.tar.gz -O depends/sdk-sources/MacOSX${OSX_SDK}.sdk.tar.gz; fi
- if [ -n "$OSX_SDK" -a ! -f depends/sdk-sources/MacOSX${OSX_SDK}.sdk.tar.gz ]; then curl --location --fail $SDK_URL/MacOSX${OSX_SDK}.sdk.tar.gz -o depends/sdk-sources/MacOSX${OSX_SDK}.sdk.tar.gz; fi
- if [ -n "$OSX_SDK" -a -f depends/sdk-sources/MacOSX${OSX_SDK}.sdk.tar.gz ]; then tar -C depends/SDKs -xf depends/sdk-sources/MacOSX${OSX_SDK}.sdk.tar.gz; fi
- make $MAKEJOBS -C depends HOST=$HOST $DEP_OPTS
script:
- if [ -n "$USE_SHELL" ]; then export CONFIG_SHELL="$USE_SHELL"; fi
- OUTDIR=$BASE_OUTDIR/$TRAVIS_PULL_REQUEST/$TRAVIS_JOB_NUMBER-$HOST
- BITCOIN_CONFIG_ALL="--disable-dependency-tracking --prefix=$TRAVIS_BUILD_DIR/depends/$HOST --bindir=$OUTDIR/bin --libdir=$OUTDIR/lib"
- depends/$HOST/native/bin/ccache --max-size=$CCACHE_SIZE
- if [ "$TRAVIS_PULL_REQUEST" != "false" ]; then export CCACHE_READONLY=1; fi
- test -n "$USE_SHELL" && eval '"$USE_SHELL" -c "./autogen.sh"' || ./autogen.sh
- ./configure --cache-file=config.cache $BITCOIN_CONFIG_ALL $BITCOIN_CONFIG || ( cat config.log && false)
- make distdir PACKAGE=bitcoin VERSION=$HOST
2 changes: 2 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -95,6 +95,8 @@ Anyone may participate in peer review which is expressed by comments in the pull
- Concept ACK means "I agree in the general principle of this pull request";
- Nit refers to trivial, often non-blocking issues.

Reviewers should include the commit hash which they reviewed in their comments.

Project maintainers reserve the right to weigh the opinions of peer reviewers using common sense judgement and also may weight based on meritocracy: Those that have demonstrated a deeper commitment and understanding towards the project (over time) or have clear domain expertise may naturally have more weight, as one would expect in all walks of life.

Where a patch set affects consensus critical code, the bar will be set much higher in terms of discussion and peer review requirements, keeping in mind that mistakes could be very costly to the wider community. This includes refactoring of consensus critical code.
2 changes: 1 addition & 1 deletion COPYING
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
The MIT License (MIT)

Copyright (c) 2009-2015 The Bitcoin Core developers
Copyright (c) 2009-2016 The Bitcoin Core developers

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
10 changes: 9 additions & 1 deletion Makefile.am
Original file line number Diff line number Diff line change
@@ -12,6 +12,7 @@ endif
BITCOIND_BIN=$(top_builddir)/src/bitcoind$(EXEEXT)
BITCOIN_QT_BIN=$(top_builddir)/src/qt/bitcoin-qt$(EXEEXT)
BITCOIN_CLI_BIN=$(top_builddir)/src/bitcoin-cli$(EXEEXT)
WALLET_UTILITY_BIN=$(top_builddir)/src/wallet-utility$(EXEEXT)
BITCOIN_WIN_INSTALLER=$(PACKAGE)-$(PACKAGE_VERSION)-win$(WINDOWS_BITS)-setup$(EXEEXT)

OSX_APP=Bitcoin-Qt.app
@@ -26,6 +27,9 @@ OSX_QT_TRANSLATIONS = da,de,es,hu,ru,uk,zh_CN,zh_TW

DIST_DOCS = $(wildcard doc/*.md) $(wildcard doc/release-notes/*.md)

BIN_CHECKS=$(top_srcdir)/contrib/devtools/symbol-check.py \
$(top_srcdir)/contrib/devtools/security-check.py

WINDOWS_PACKAGING = $(top_srcdir)/share/pixmaps/bitcoin.ico \
$(top_srcdir)/share/pixmaps/nsis-header.bmp \
$(top_srcdir)/share/pixmaps/nsis-wizard.bmp \
@@ -60,6 +64,7 @@ $(BITCOIN_WIN_INSTALLER): all-recursive
STRIPPROG="$(STRIP)" $(INSTALL_STRIP_PROGRAM) $(BITCOIND_BIN) $(top_builddir)/release
STRIPPROG="$(STRIP)" $(INSTALL_STRIP_PROGRAM) $(BITCOIN_QT_BIN) $(top_builddir)/release
STRIPPROG="$(STRIP)" $(INSTALL_STRIP_PROGRAM) $(BITCOIN_CLI_BIN) $(top_builddir)/release
STRIPPROG="$(STRIP)" $(INSTALL_STRIP_PROGRAM) $(WALLET_UTILITY_BIN) $(top_builddir)/release
@test -f $(MAKENSIS) && $(MAKENSIS) -V2 $(top_builddir)/share/setup.nsi || \
echo error: could not build $@
@echo built $@
@@ -142,6 +147,9 @@ $(BITCOIND_BIN): FORCE
$(BITCOIN_CLI_BIN): FORCE
$(MAKE) -C src $(@F)

$(WALLET_UTILITY_BIN): FORCE
$(MAKE) -C src $(@F)

if USE_LCOV

baseline.info:
@@ -213,7 +221,7 @@ endif

dist_noinst_SCRIPTS = autogen.sh

EXTRA_DIST = $(top_srcdir)/share/genbuild.sh qa/pull-tester/rpc-tests.py qa/rpc-tests $(DIST_DOCS) $(WINDOWS_PACKAGING) $(OSX_PACKAGING)
EXTRA_DIST = $(top_srcdir)/share/genbuild.sh qa/pull-tester/rpc-tests.py qa/rpc-tests $(DIST_DOCS) $(WINDOWS_PACKAGING) $(OSX_PACKAGING) $(BIN_CHECKS)

CLEANFILES = $(OSX_DMG) $(BITCOIN_WIN_INSTALLER)

7 changes: 4 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
@@ -3,7 +3,7 @@ Bitcoin Core integration/staging tree

[![Build Status](https://travis-ci.org/bitcoin/bitcoin.svg?branch=master)](https://travis-ci.org/bitcoin/bitcoin)

https://www.bitcoin.org
https://bitcoincore.org

What is Bitcoin?
----------------
@@ -15,13 +15,14 @@ out collectively by the network. Bitcoin Core is the name of open source
software which enables the use of this currency.

For more information, as well as an immediately useable, binary version of
the Bitcoin Core software, see https://www.bitcoin.org/en/download.
the Bitcoin Core software, see https://bitcoin.org/en/download, or read the
[original whitepaper](https://bitcoincore.org/bitcoin.pdf).

License
-------

Bitcoin Core is released under the terms of the MIT license. See [COPYING](COPYING) for more
information or see http://opensource.org/licenses/MIT.
information or see https://opensource.org/licenses/MIT.

Development Process
-------------------
45 changes: 27 additions & 18 deletions configure.ac
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
dnl require autoconf 2.60 (AS_ECHO/AS_ECHO_N)
AC_PREREQ([2.60])
define(_CLIENT_VERSION_MAJOR, 0)
define(_CLIENT_VERSION_MINOR, 11)
define(_CLIENT_VERSION_REVISION, 99)
define(_CLIENT_VERSION_MINOR, 12)
define(_CLIENT_VERSION_REVISION, 1)
define(_CLIENT_VERSION_BUILD, 0)
define(_CLIENT_VERSION_IS_RELEASE, false)
define(_COPYRIGHT_YEAR, 2015)
define(_CLIENT_VERSION_IS_RELEASE, true)
define(_COPYRIGHT_YEAR, 2016)
AC_INIT([Bitcoin Core],[_CLIENT_VERSION_MAJOR._CLIENT_VERSION_MINOR._CLIENT_VERSION_REVISION],[https://github.com/bitcoin/bitcoin/issues],[bitcoin])
AC_CONFIG_SRCDIR([src/main.cpp])
AC_CONFIG_HEADERS([src/config/bitcoin-config.h])
@@ -64,6 +64,8 @@ AC_PATH_PROG([GIT], [git])
AC_PATH_PROG(CCACHE,ccache)
AC_PATH_PROG(XGETTEXT,xgettext)
AC_PATH_PROG(HEXDUMP,hexdump)
AC_PATH_TOOL(READELF, readelf)
AC_PATH_TOOL(CPPFILT, c++filt)

dnl pkg-config check.
PKG_PROG_PKG_CONFIG
@@ -92,6 +94,11 @@ AC_ARG_ENABLE(tests,
[use_tests=$enableval],
[use_tests=yes])

AC_ARG_ENABLE(gui-tests,
AS_HELP_STRING([--disable-gui-tests],[do not compile GUI tests (default is to compile if GUI and tests enabled)]),
[use_gui_tests=$enableval],
[use_gui_tests=$use_tests])

AC_ARG_ENABLE(bench,
AS_HELP_STRING([--disable-bench],[do not compile benchmarks (default is to compile)]),
[use_bench=$enableval],
@@ -184,7 +191,7 @@ CPPFLAGS="$CPPFLAGS -DHAVE_BUILD_INFO -D__STDC_FORMAT_MACROS"

AC_ARG_WITH([utils],
[AS_HELP_STRING([--with-utils],
[build bitcoin-cli bitcoin-tx (default=yes)])],
[build bitcoin-cli bitcoin-tx wallet-utility (default=yes)])],
[build_bitcoin_utils=$withval],
[build_bitcoin_utils=yes])

@@ -409,6 +416,10 @@ AX_GCC_FUNC_ATTRIBUTE([dllimport])

if test x$use_glibc_compat != xno; then

#glibc absorbed clock_gettime in 2.17. librt (its previous location) is safe to link
#in anyway for back-compat.
AC_CHECK_LIB([rt],[clock_gettime],, AC_MSG_ERROR(lib missing))

#__fdelt_chk's params and return type have changed from long unsigned int to long int.
# See which one is present here.
AC_MSG_CHECKING(__fdelt_chk type)
@@ -422,7 +433,8 @@ if test x$use_glibc_compat != xno; then
[ fdelt_type="long int"])
AC_MSG_RESULT($fdelt_type)
AC_DEFINE_UNQUOTED(FDELT_TYPE, $fdelt_type,[parameter and return value type for __fdelt_chk])

else
AC_SEARCH_LIBS([clock_gettime],[rt])
fi

if test x$TARGET_OS != xwindows; then
@@ -489,8 +501,6 @@ AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[#include <sys/socket.h>]],
[ AC_MSG_RESULT(no)]
)

AC_SEARCH_LIBS([clock_gettime],[rt])

AC_MSG_CHECKING([for visibility attribute])
AC_LINK_IFELSE([AC_LANG_SOURCE([
int foo_def( void ) __attribute__((visibility("default")));
@@ -756,7 +766,7 @@ AC_MSG_CHECKING([whether to build bitcoind])
AM_CONDITIONAL([BUILD_BITCOIND], [test x$build_bitcoind = xyes])
AC_MSG_RESULT($build_bitcoind)

AC_MSG_CHECKING([whether to build utils (bitcoin-cli bitcoin-tx)])
AC_MSG_CHECKING([whether to build utils (bitcoin-cli bitcoin-tx wallet-utility)])
AM_CONDITIONAL([BUILD_BITCOIN_UTILS], [test x$build_bitcoin_utils = xyes])
AC_MSG_RESULT($build_bitcoin_utils)

@@ -827,8 +837,8 @@ else
fi

dnl these are only used when qt is enabled
BUILD_TEST_QT=""
if test x$bitcoin_enable_qt != xno; then
BUILD_QT=qt
dnl enable dbus support
AC_MSG_CHECKING([whether to build GUI with support for D-Bus])
if test x$bitcoin_enable_qt_dbus != xno; then
@@ -858,9 +868,9 @@ if test x$bitcoin_enable_qt != xno; then
fi

AC_MSG_CHECKING([whether to build test_bitcoin-qt])
if test x$use_tests$bitcoin_enable_qt_test = xyesyes; then
if test x$use_gui_tests$bitcoin_enable_qt_test = xyesyes; then
AC_MSG_RESULT([yes])
BUILD_TEST_QT="test"
BUILD_TEST_QT="yes"
else
AC_MSG_RESULT([no])
fi
@@ -871,9 +881,10 @@ AM_CONDITIONAL([ENABLE_ZMQ], [test "x$use_zmq" = "xyes"])
AC_MSG_CHECKING([whether to build test_bitcoin])
if test x$use_tests = xyes; then
AC_MSG_RESULT([yes])
BUILD_TEST="test"
BUILD_TEST="yes"
else
AC_MSG_RESULT([no])
BUILD_TEST=""
fi

AC_MSG_CHECKING([whether to reduce exports])
@@ -891,15 +902,16 @@ AM_CONDITIONAL([TARGET_DARWIN], [test x$TARGET_OS = xdarwin])
AM_CONDITIONAL([BUILD_DARWIN], [test x$BUILD_OS = xdarwin])
AM_CONDITIONAL([TARGET_WINDOWS], [test x$TARGET_OS = xwindows])
AM_CONDITIONAL([ENABLE_WALLET],[test x$enable_wallet = xyes])
AM_CONDITIONAL([ENABLE_TESTS],[test x$use_tests = xyes])
AM_CONDITIONAL([ENABLE_TESTS],[test x$BUILD_TEST = xyes])
AM_CONDITIONAL([ENABLE_QT],[test x$bitcoin_enable_qt = xyes])
AM_CONDITIONAL([ENABLE_QT_TESTS],[test x$use_tests$bitcoin_enable_qt_test = xyesyes])
AM_CONDITIONAL([ENABLE_QT_TESTS],[test x$BUILD_TEST_QT = xyes])
AM_CONDITIONAL([ENABLE_BENCH],[test x$use_bench = xyes])
AM_CONDITIONAL([USE_QRCODE], [test x$use_qr = xyes])
AM_CONDITIONAL([USE_LCOV],[test x$use_lcov = xyes])
AM_CONDITIONAL([USE_COMPARISON_TOOL],[test x$use_comparison_tool != xno])
AM_CONDITIONAL([USE_COMPARISON_TOOL_REORG_TESTS],[test x$use_comparison_tool_reorg_test != xno])
AM_CONDITIONAL([GLIBC_BACK_COMPAT],[test x$use_glibc_compat = xyes])
AM_CONDITIONAL([HARDEN],[test x$use_hardening = xyes])

AC_DEFINE(CLIENT_VERSION_MAJOR, _CLIENT_VERSION_MAJOR, [Major version])
AC_DEFINE(CLIENT_VERSION_MINOR, _CLIENT_VERSION_MINOR, [Minor version])
@@ -926,9 +938,6 @@ AC_SUBST(USE_QRCODE)
AC_SUBST(BOOST_LIBS)
AC_SUBST(TESTDEFS)
AC_SUBST(LEVELDB_TARGET_FLAGS)
AC_SUBST(BUILD_TEST)
AC_SUBST(BUILD_QT)
AC_SUBST(BUILD_TEST_QT)
AC_SUBST(MINIUPNPC_CPPFLAGS)
AC_SUBST(MINIUPNPC_LIBS)
AC_CONFIG_FILES([Makefile src/Makefile share/setup.nsi share/qt/Info.plist src/test/buildenv.py])
2 changes: 1 addition & 1 deletion contrib/debian/control
Original file line number Diff line number Diff line change
@@ -23,7 +23,7 @@ Build-Depends: debhelper,
libprotobuf-dev, protobuf-compiler,
python
Standards-Version: 3.9.2
Homepage: https://www.bitcoin.org/
Homepage: https://bitcoincore.org/
Vcs-Git: git://github.com/bitcoin/bitcoin.git
Vcs-Browser: https://github.com/bitcoin/bitcoin

2 changes: 1 addition & 1 deletion contrib/debian/copyright
Original file line number Diff line number Diff line change
@@ -5,7 +5,7 @@ Upstream-Contact: Satoshi Nakamoto <satoshin@gmx.com>
Source: https://github.com/bitcoin/bitcoin

Files: *
Copyright: 2009-2015, Bitcoin Core Developers
Copyright: 2009-2016, Bitcoin Core Developers
License: Expat
Comment: The Bitcoin Core Developers encompasses the current developers listed on bitcoin.org,
as well as the numerous contributors to the project.
28 changes: 2 additions & 26 deletions contrib/debian/manpages/bitcoin-cli.1
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
.TH BITCOIN-CLI "1" "February 2015" "bitcoin-cli 0.10"
.TH BITCOIN-CLI "1" "February 2016" "bitcoin-cli 0.12"
.SH NAME
bitcoin-cli \- a remote procedure call client for Bitcoin Core.
.SH SYNOPSIS
@@ -11,31 +11,7 @@ This manual page documents the bitcoin-cli program. bitcoin-cli is an RPC client
.SH OPTIONS
.TP
\fB\-?\fR
Show the help message.
.TP
\fB\-conf=\fR<file>
Specify configuration file (default: bitcoin.conf).
.TP
\fB\-datadir=\fR<dir>
Specify data directory.
.TP
\fB\-testnet\fR
Connect to a Bitcoin Core instance running in testnet mode.
.TP
\fB\-regtest\fR
Connect to a Bitcoin Core instance running in regtest mode (see documentation for -regtest on bitcoind).
.TP
\fB\-rpcuser=\fR<user>
Username for JSON\-RPC connections.
.TP
\fB\-rpcpassword=\fR<pw>
Password for JSON\-RPC connections.
.TP
\fB\-rpcport=\fR<port>
Listen for JSON\-RPC connections on <port> (default: 8332 or testnet: 18332).
.TP
\fB\-rpcconnect=\fR<ip>
Send commands to node running on <ip> (default: 127.0.0.1).
Show possible options.

.SH "SEE ALSO"
\fBbitcoind\fP, \fBbitcoin.conf\fP
Loading