fix: Specify the config export download filename in the modern way #3243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at's interpreted identically in all modern browsers. (bitfocus#3242)
jswalden
force-pushed
the
export-file-name-specialchars
branch
from
8a923e5 to
c80b1b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3242. I got bogged down where I was, so I was able to test this in Safari (as well as the more cross-platform Firefox and Chrome).
I believe this is a bugfix that could reasonably be taken in a point release (although I developed it against
mainand haven't checked whether it would backport). I actually ran into this trying to avail myself of this using the current.companionconfignaming style I have for my own site backups when I make changes (in this case, after doing thes/internal:custom_/custom:/gchange throughout my configuration), and it would be nice to be able to make use of this feature and not change my previous naming style to work around this.