feat: rework control entities #3185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP for 3.6
The aim of this is to rework how we handle actions and feedbacks into a single type called entity.
There is still action and feedback specialisation of entities, but as maybe 80% of the code for them is the same and is currently duplicated, combining them allows us to the model.
The key benefit and motivator of this, is that it makes things much simpler when it comes to having feedbacks inside of actions (for an if action). Without doing this, making sure that we perform the correct lifecycle and mutations of these feedbacks is very hard and messy, and going forward would be error prone making sure that both places attempt to be updated.
TODO