Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: v3.4 Wizard Update #2867

Merged
merged 6 commits into from
May 22, 2024
Merged

feat: v3.4 Wizard Update #2867

merged 6 commits into from
May 22, 2024

Conversation

krocheck
Copy link
Member

This adds Videohub Panel listener enable to the Surfaces tab and a new Button Grid size tab. It also adds a couple UI bits to the Settings tab to show the total number of rows and columns in the grid and cleans up the design of the Surfaces tab.

image image image image

@krocheck krocheck requested a review from Julusian May 18, 2024 14:44
@krocheck krocheck changed the title v3.4: Wizard Update feat: v3.4 Wizard Update May 18, 2024
@haakonnessjoen
Copy link
Member

From Keith:
Here's an update. I changed the logic so it detects if minRow or minCol are not 0 and bypasses the step in that case.

image

Looks good, but I think it would be nice to add some text to clarify that it can be changed later. Or else the user might think this is something that has to be decided right as they see this screen.

@krocheck
Copy link
Member Author

@haakonnessjoen
image

@krocheck krocheck force-pushed the feat/wizard-update branch from 3efcfaf to 5301913 Compare May 22, 2024 15:40
@krocheck krocheck merged commit e772ff4 into main May 22, 2024
11 of 13 checks passed
@krocheck krocheck deleted the feat/wizard-update branch May 22, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants