feat: add installName userconfig #2866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julusian
approved these changes
May 20, 2024
There was a problem hiding this comment.
I'm wondering what the default value should be.
Do we need to bake in 'Bitfocus Companion' as the default value, or would it be better to have an empty string, with that default inserted at the place of using it?
I've never been that keen on how the default page name is 'PAGE', giving that value some special properties.
Part of me wants this when unset to use the hostname of the machine, but I'm not sure that would be a good idea
|
I can switch this to be empty by default and replace/override 'Bitfocus Companion' in the title bar instead if that's preferred. |
krocheck
force-pushed
the
feat/document-titles
branch
from
75c7b64 to
149156e
Compare
Julusian
reviewed
May 22, 2024
Julusian
reviewed
May 22, 2024
|
@Julusian I think this is ready to go now if you want to give a fresh look. |
Julusian
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
userconfigfield calledinstallNamethat defaults to "Bitfocus Companion" but when modified changes the browser titles and adds the name to the left of the version in the Admin header.The functionality can be useful in larger show networks when users might be configuring or utilizing Companion on more than one machine.
Closes #2813 and partially responds to #2498
TODO: