[BUG] Updating to v3.4.0 broke support for unicode fonts in Button text strings

[themanjotsingh]

Is this a bug in companion itself or a module?

• I believe this to be a bug in companion

Is there an existing issue for this?

• I have searched the existing issues

Describe the bug

On v3.3.1 and prior, unicode fonts rendered fine for button text as shown in image1.

After updating to v3.4.0, they do not render properly as shown in image2.

I have checked by exporting and importing to an older install to confirm that I am able to still see the text when viewing from older install. Same pc/browser, nothing else has changed.

Steps To Reproduce

No response

Expected Behavior

No response

Environment (please complete the following information)

- OS: Windows 11
- Browser: Firefox 130.0
- Companion Version: v3.3.1 -> v3.4.0

Additional context

No response

[Julusian]

This is annoying to hear. But at least it's not doing what 3.3 did when encountering some unicode fonts which was to crash.
I'll take a look into this soon. Could you provide an example bit of text that doesn't work in a comment of this issue? That should make it easy to reproduce your exact issue and confirm when it is fixed (as other characters do work)

[themanjotsingh]

Yes, true. Better than crashing. We'll write in English for now.

Here's a few examples of strings: ਤਖ਼ਤ, ਕੀਰਤਨ

Language is Panjabi/Punjabi, written in the Gurmukhi Script.

Thanks for your help!

[RabbitJun]

I also noticed that this doesn't work in Chinese v3.3.1 -> v3.4.0。'节目' has become □□

[jwetzell]

This break was introduced with this #2785.

[Julusian]

What has happened is that the old canvas library would fallback to using system fonts for any characters not included in the font used by companion. But the new canvas library does not do that.

I don't remember if this was semi-intentional, because what it finds on the system varies depending on OS, which makes portability of configs inconsistent.

I've added the Gurmukhi and Simplified Chinese portions of the font we use, so the examples provided here now draw as expected.

If anyone has examples of another character set that is missing, open an issue and it can be added.

This is in the betas now, and will be in 3.4.1 soon

[scientastic]

I can't get Korean characters (한글) to show:

[Julusian]

I have added the korean character set, which will be in the betas shortly and next release

[scientastic]

Thanks! Confirmed in 3.4.2 👍