-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix show only personal setting not updating the view immediately #1238
Merged
rfc2822
merged 11 commits into
main-ose
from
1231-ui-show-only-personal-is-only-effective-when-opening-collection-list-again
Jan 20, 2025
Merged
Fix show only personal setting not updating the view immediately #1238
rfc2822
merged 11 commits into
main-ose
from
1231-ui-show-only-personal-is-only-effective-when-opening-collection-list-again
Jan 20, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ad96c46
to
c527b85
Compare
rfc2822
reviewed
Jan 16, 2025
app/src/main/kotlin/at/bitfire/davdroid/ui/account/GetServiceCollectionPagerUseCase.kt
Show resolved
Hide resolved
rfc2822
requested changes
Jan 17, 2025
app/src/main/kotlin/at/bitfire/davdroid/ui/account/AccountScreenModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/at/bitfire/davdroid/ui/account/GetServiceCollectionPagerUseCase.kt
Show resolved
Hide resolved
app/src/main/kotlin/at/bitfire/davdroid/ui/account/AccountScreenModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/at/bitfire/davdroid/settings/AccountSettings.kt
Outdated
Show resolved
Hide resolved
rfc2822
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good & works in what I have tested 👍🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix show only personal setting not updating the view.
Short description
getShowOnlyPersonalPair
methodviewModelScope
instead ofCoroutineScope(Dispatchers.Default)
flatMapConcat
which waits for the inner flow to finish before emitting new values even ifshowOnlyPersonalFlow
emitted new values. Now we are usingflatMapLatest
which will cancel the inner flow instead of waiting. Note also that usingflattenMerge
would also work, but probably creates unnecessary overhead as it continuously merges emits from both the inner and outer flow, which we don't need.Checklist