Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BIP327: Fix Broken Links #1549

Merged
merged 1 commit into from
Apr 22, 2024
Merged

BIP327: Fix Broken Links #1549

merged 1 commit into from
Apr 22, 2024

Conversation

siv2r
Copy link
Contributor

@siv2r siv2r commented Feb 1, 2024

  • Negation Of The Seckey When Signing link
    • add the missing "#"
  • Indentifiying Disruptive Signers link
    • remove “i” after “f”
  • Signing Flow link
    • should be General Signing Flow instead

@vostrnad
Copy link
Contributor

vostrnad commented Feb 1, 2024

ACK 1dbf71b

jonasnick
jonasnick approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@jonasnick jonasnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

ACK 1dbf71b

0xGRAV3R
0xGRAV3R approved these changes Feb 23, 2024
View reviewed changes
Copy link

@0xGRAV3R 0xGRAV3R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked and reviewed the three changes & fixes for the broken links and these are good to go

0xtrr
0xtrr approved these changes Feb 24, 2024
View reviewed changes
Copy link

@0xtrr 0xtrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack. Verified that the updated links didn't work before and works as expected now.

@siv2r
Copy link
Contributor Author

siv2r commented Feb 26, 2024

Added the following fix too:

The link for mandatory pk in nonce gen should redirect to the "signing with tweaked individual keys" section, not "modification to nonce generation".

@jonasnick
Copy link
Contributor

ACK ddf5b25

Same fix is also in #1544 (do you want to close that @real-or-random?).

real-or-random
real-or-random approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@real-or-random real-or-random left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ddf5b25

@real-or-random real-or-random mentioned this pull request Feb 26, 2024
Closed
@real-or-random
Copy link
Contributor

Thanks @siv2r!

Hint: In this repo, it makes sense to @mention the BIP authors in any PRs and issues. I wasn't aware of this PR. (It's not possible to enable notifications for single BIPs, you can only do it for the entire repo...)

kristapsk
kristapsk approved these changes Feb 26, 2024
View reviewed changes
Copy link

@kristapsk kristapsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ddf5b25

@siv2r
Copy link
Contributor Author

siv2r commented Feb 26, 2024 •
edited
Loading

Same fix is also in #1544

Sorry missed this PR.

jonatack
jonatack approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@jonatack jonatack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@jonatack jonatack merged commit d1cde72 into bitcoin:master Apr 22, 2024
3 checks passed
@bitcoin bitcoin deleted a comment from Originalmenace Apr 23, 2024
@siv2r siv2r deleted the bip327-fix-link branch April 23, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@real-or-random real-or-random real-or-random approved these changes

@jonatack jonatack jonatack approved these changes

@jonasnick jonasnick jonasnick approved these changes

@kristapsk kristapsk kristapsk approved these changes

@0xtrr 0xtrr 0xtrr approved these changes

@Originalmenace Originalmenace Originalmenace approved these changes

@0xGRAV3R 0xGRAV3R 0xGRAV3R approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@siv2r @vostrnad @jonasnick @real-or-random @jonatack @kristapsk @0xtrr @Originalmenace @0xGRAV3R