Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Offer: navigating back on a sell trade shows the reputation warning again #193

Open
rodvar opened this issue Feb 6, 2025 · 2 comments
Open

Create Offer: navigating back on a sell trade shows the reputation warning again #193

rodvar opened this issue Feb 6, 2025 · 2 comments
Assignees
@nostrbuddha
Labels
low-prio issue is low priority whilst having this label Trading issue is related to the core functionality of trading UI
Milestone
MVP (version 0.1.0)

Comments

@rodvar
Copy link
Collaborator

rodvar commented Feb 6, 2025

  1. open the app
  2. go to the offerbook (buy/sell tab)
  3. tap on the "+" to create a new offer
  4. select sell. Observer reputation warning
  5. click "continue without reputation"
  6. tap on "back"
  7. observe

ER: buy/sell selector is shown with sell selected
OR: the warning dialog gets shown again

tech comment

probably better to bind the show warning action to the tapping of the "next" button action to fix this.
@rodvar rodvar added low-prio issue is low priority whilst having this label UI labels Feb 6, 2025
@rodvar rodvar added this to the MVP (version 0.1.0) milestone Feb 6, 2025
@rodvar
Copy link
Collaborator Author

rodvar commented Feb 6, 2025

@nostrbuddha would you like to take this one?

@nostrbuddha
Copy link
Contributor

Yes. I will do this

@rodvar rodvar added the Trading issue is related to the core functionality of trading label Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nostrbuddha nostrbuddha

Labels
low-prio issue is low priority whilst having this label Trading issue is related to the core functionality of trading UI
Projects
None yet
Milestone
MVP (version 0.1.0)
Development

No branches or pull requests
2 participants
@rodvar @nostrbuddha