From cbc63a0486312ca198169fdfac4e97402ec92e91 Mon Sep 17 00:00:00 2001 From: bbimber Date: Mon, 29 Jul 2024 05:16:00 -0700 Subject: [PATCH] Minor code improvements --- .../org/labkey/api/ldk/buttons/ShowEditUIButton.java | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/LDK/api-src/org/labkey/api/ldk/buttons/ShowEditUIButton.java b/LDK/api-src/org/labkey/api/ldk/buttons/ShowEditUIButton.java index b3892cd7..7d47429e 100644 --- a/LDK/api-src/org/labkey/api/ldk/buttons/ShowEditUIButton.java +++ b/LDK/api-src/org/labkey/api/ldk/buttons/ShowEditUIButton.java @@ -38,11 +38,13 @@ public class ShowEditUIButton extends SimpleButtonConfigFactory protected Class[] _perms; + @SafeVarargs public ShowEditUIButton(Module owner, String schemaName, String queryName, Class... perms) { this(owner, schemaName, queryName, "Edit Records", perms); } + @SafeVarargs public ShowEditUIButton(Module owner, String schemaName, String queryName, String label, Class... perms) { super(owner, label, ""); @@ -87,20 +89,20 @@ protected String getJsHandler(TableInfo ti) { String schema = _schemaName == null || LDKService.ALL_SCHEMAS.equals(_schemaName) ? ti.getPublicSchemaName() : _schemaName; String query = _queryName == null || LDKService.ALL_TABLES.equalsIgnoreCase(_queryName) ? ti.getPublicName() : _queryName; - String ret = getHandlerName() + "(" + PageFlowUtil.jsString(schema) + "," + PageFlowUtil.jsString(query) + ",dataRegionName, {"; + StringBuilder ret = new StringBuilder(getHandlerName() + "(" + PageFlowUtil.jsString(schema) + "," + PageFlowUtil.jsString(query) + ",dataRegionName, {"); String delim = ""; if (_urlParamMap != null) { for (String key : _urlParamMap.keySet()) { - ret += delim + PageFlowUtil.jsString(key) + ":" + PageFlowUtil.jsString(_urlParamMap.get(key)); + ret.append(delim).append(PageFlowUtil.jsString(key)).append(":").append(PageFlowUtil.jsString(_urlParamMap.get(key))); delim = ","; } } - ret += "}, " + _copyFilters + ");"; + ret.append("}, ").append(_copyFilters).append(");"); - return ret; + return ret.toString(); } }