Skip to content

Commit

Permalink
Bugfix for production mode schema browser bug when ExtraDataSourcesUs…
Browse files Browse the repository at this point in the history
…erSchema is active
  • Loading branch information
bbimber committed Jul 17, 2024
1 parent 4cc2422 commit 78a3d40
Showing 1 changed file with 9 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,7 @@ public TableInfo createTable(String name, ContainerFilter cf)
{
if (!getContainer().isWorkbook() || source.isImportIntoWorkbooks())
{
// TODO: QueryDefinition.getTable doesn't yet have ContainerFilter option
TableInfo ti = source.getTableInfo(getContainer(), getUser());
TableInfo ti = createWrappedTable(name, source.getTableInfo(getContainer(), getUser()), cf);
new WrappingTableCustomizer().customize(ti);

return ti;
Expand All @@ -65,6 +64,14 @@ public TableInfo createTable(String name, ContainerFilter cf)
return null;
}

@Override
protected void afterConstruct(TableInfo info)
{
// No-op to avoid double-adding query metadata. Rely on the source table for this.
// This bug appears in the schema browser in production mode only. If there is a container with any extra data sources present, the table details
// page will asynchronously load an 'Error: null' message, coming from the query analyzer
}

@Override
public DbSchema getDbSchema()
{
Expand Down

0 comments on commit 78a3d40

Please sign in to comment.