Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for mGAP annotations to supply InDefaultFields #145

Merged
merged 4 commits into from
Dec 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
ALTER TABLE mGAP.annotations ADD inDefaultColumns boolean;
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
ALTER TABLE mGAP.annotations ADD inDefaultColumns bit;
3 changes: 3 additions & 0 deletions mGAP/resources/schemas/mgap.xml
Original file line number Diff line number Diff line change
Expand Up @@ -1224,6 +1224,9 @@
<column columnName="allowableValues">
<columnTitle>Allowable Values</columnTitle>
</column>
<column columnName="inDefaultColumns">
<columnTitle>In Default Columns?</columnTitle>
</column>
<column columnName="container">
<isHidden>true</isHidden>
</column>
Expand Down
11 changes: 11 additions & 0 deletions mGAP/src/org/labkey/mgap/jbrowse/AnnotationModel.java
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ public class AnnotationModel
private String _formatString;
private Boolean _hidden = false;
private Boolean _isIndexed = false;
private Boolean _inDefaultColumns = false;
private String _allowableValues;

public AnnotationModel()
Expand Down Expand Up @@ -183,4 +184,14 @@ public void setAllowableValues(String allowableValues)
{
_allowableValues = allowableValues;
}

public Boolean isInDefaultColumns()
{
return _inDefaultColumns;
}

public void setInDefaultColumns(Boolean inDefaultColumns)
{
_inDefaultColumns = inDefaultColumns;
}
}
5 changes: 5 additions & 0 deletions mGAP/src/org/labkey/mgap/jbrowse/mGAPFieldCustomizer.java
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,11 @@ else if (ams.size() > 1)
field.setIndexed(true);
}

if (am.isInDefaultColumns())
{
field.setInDefaultColumns(true);
}

if (StringUtils.trimToNull(am.getDescription()) != null)
{
field.setDescription(am.getDescription());
Expand Down
1 change: 1 addition & 0 deletions mGAP/src/org/labkey/mgap/mGAPController.java
Original file line number Diff line number Diff line change
Expand Up @@ -1209,6 +1209,7 @@ public boolean handlePost(Object o, BindException errors) throws Exception
getOptionalField(line, header, "FormatString", row, "formatString");
getOptionalField(line, header, "AllowableValues", row, "allowableValues");
getOptionalField(line, header, "IsIndexed", row, "isIndexed");
getOptionalField(line, header, "InDefaultColumns", row, "inDefaultColumns");

toAdd.add(row);
}
Expand Down
2 changes: 1 addition & 1 deletion mGAP/src/org/labkey/mgap/mGAPManager.java
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ public Set<User> getNotificationUsers()

if (u == null)
{
_log.error("Unknown user registered for mGAP notifcations: " + username);
_log.error("Unknown user registered for mGAP notifications: " + username);
}

if (u != null)
Expand Down
2 changes: 1 addition & 1 deletion mGAP/src/org/labkey/mgap/mGAPModule.java
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ public String getName()
@Override
public Double getSchemaVersion()
{
return 16.70;
return 16.71;
}

@Override
Expand Down