Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase code coverage #357

Merged
merged 6 commits into from
Jan 7, 2025
Merged

Increase code coverage #357

merged 6 commits into from
Jan 7, 2025

Conversation

DBartlettHP
Copy link
Collaborator

Achieving 100% code coverage on

-add.interval.col.R
-assertions.R

@billdenney billdenney changed the title Adding testing coverage to some lines of code Increase code coverage Jan 4, 2025
@DBartlettHP
Copy link
Collaborator Author

DBartlettHP commented Jan 6, 2025

  • adding a nocov to cover when clast is NA

  • auciv.R contains a few new changes that I need to add a test for, however, my local machine does not contain these changes yet. [testing check = FALSE]

    pknca/R/auciv.R

    Lines 23 to 34 in b42d114

    pk.calc.auciv <- function(conc, time, c0, auc, ..., options = list(), check=TRUE) {
    if (check) {
    assert_conc_time(conc = conc, time = time)
    data <-
    clean.conc.blq(
    conc, time,
    options = options,
    check=FALSE
    )
    } else {
    data <- data.frame(conc = conc, time = time)
    }

@billdenney
Copy link
Owner

Can you please also fix these two issues (by changing na.omit() to stats::na.omit() on the indicated lines?

PKNCAdata.default: no visible global function definition for ‘na.omit’
  (/home/runner/work/pknca/pknca/check/PKNCA.Rcheck/00_pkg_src/PKNCA/R/class-PKNCAdata.R:186)
PKNCAdata.default: no visible global function definition for ‘na.omit’
  (/home/runner/work/pknca/pknca/check/PKNCA.Rcheck/00_pkg_src/PKNCA/R/class-PKNCAdata.R:193)

@billdenney billdenney merged commit cdc4c07 into main Jan 7, 2025
10 checks passed
@billdenney billdenney deleted the increasing_code_coverage branch January 7, 2025 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants