From d02e9d6f7886dbab4cc3b7e8a438bf3e7415b86e Mon Sep 17 00:00:00 2001 From: bilalekrem Date: Sun, 15 Nov 2020 14:57:22 +0300 Subject: [PATCH] remove txt record with its value --- Makefile | 2 +- setup.py | 2 +- windowsdnsserver/dns/base.py | 2 +- windowsdnsserver/dns/dnsserver.py | 5 ++++- 4 files changed, 7 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index 923d250..a87bd76 100644 --- a/Makefile +++ b/Makefile @@ -7,7 +7,7 @@ twine = ${python} -m twine pip = ${python} -m pip install-local: build-module - ${pip} uninstall windowsdnsserver-py + ${pip} uninstall -y windowsdnsserver-py ${pip} install windowsdnsserver-py --no-index --find-links dist/ upload: build-module diff --git a/setup.py b/setup.py index 8ba1efb..75d1187 100644 --- a/setup.py +++ b/setup.py @@ -5,7 +5,7 @@ setuptools.setup( name="windowsdnsserver-py", - version="0.0.1", + version="0.0.2.dev1", author="Bilal Ekrem Harmansa", author_email="bilalekremharmansa@gmail.com", description="wrapper Python library for Windows Server DnsServer module", diff --git a/windowsdnsserver/dns/base.py b/windowsdnsserver/dns/base.py index 3be91b1..a356ecf 100644 --- a/windowsdnsserver/dns/base.py +++ b/windowsdnsserver/dns/base.py @@ -21,5 +21,5 @@ def remove_a_record(self, zone: str, name: str) -> bool: def add_txt_record(self, zone: str, name: str, content, ttl: str) -> bool: raise MethodNotImplementedError() - def remove_txt_record(self, zone: str, name: str) -> bool: + def remove_txt_record(self, zone: str, name: str, record_data: str) -> bool: raise MethodNotImplementedError() diff --git a/windowsdnsserver/dns/dnsserver.py b/windowsdnsserver/dns/dnsserver.py index e3bf917..9dee29d 100644 --- a/windowsdnsserver/dns/dnsserver.py +++ b/windowsdnsserver/dns/dnsserver.py @@ -96,7 +96,7 @@ def add_txt_record(self, zone: str, name: str, content, ttl: str = '1h') -> bool return result.success - def remove_txt_record(self, zone: str, name: str) -> bool: + def remove_txt_record(self, zone: str, name: str, record_data: str = None) -> bool: """ uses Remove-DnsServerResourceRecord cmdlet to remove txt record in a zone """ args = { @@ -106,6 +106,9 @@ def remove_txt_record(self, zone: str, name: str) -> bool: if name: args['Name'] = name + if record_data: + args['RecordData'] = '"%s"' % record_data + flags = ['Force'] command = PowerShellCommand('Remove-DnsServerResourceRecord', *flags, **args)