Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ws: undefined is not an object (evaluating 'api.getInternalData(elt).webSocket.close') #109

Merged
merged 2 commits into from
Nov 23, 2024

Conversation

enigma
Copy link
Contributor

@enigma enigma commented Nov 14, 2024

This PR fixes #96 by checking whether webSocket is set. A similar check happens at L46 on the same file.

Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for htmx-extensions canceled.

Name Link
🔨 Latest commit 963eaff
🔍 Latest deploy log https://app.netlify.com/sites/htmx-extensions/deploys/673719cf0dd22e0008e70f95

@Telroshan Telroshan added bug Something isn't working needs test labels Nov 15, 2024
@Telroshan
Copy link
Collaborator

Hey, thanks for the fix!
Would you mind adding a test case, to avoid any potentiel regression in the future ?
You would need to make sure the test case fails with the current state, then that it succeeds with your fix

@enigma
Copy link
Contributor Author

enigma commented Nov 15, 2024

Hey, thanks for the fix! Would you mind adding a test case, to avoid any potentiel regression in the future ? You would need to make sure the test case fails with the current state, then that it succeeds with your fix

Thank you @Telroshan - please take another look.

Copy link
Collaborator

@Telroshan Telroshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@Telroshan Telroshan merged commit e87e1c3 into bigskysoftware:main Nov 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

maybeCloseWebSocketSource raises error
2 participants