Add copy&paste of BDV state as JSON strings #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typed<T> instances of any T with a @JsonIo-annotated adapter are serialized as json objects with a "type" attribute with the value of the JsonIo.type() annotation, and an "obj" attribute, which is serialized using the annotated adapter. For deserialization, the correct adapter is looked up via the "type" attribute.
|
This pull request has been mentioned on Image.sc Forum. There might be relevant details there: https://forum.image.sc/t/fiji-friends-weekly-dev-update-thread/103718/80 |
|
Hi @tpietzsch, sorry, I get two errors when using this pull request in bigstitcher, and it does not seem to work (I assumed copy&paste is somehow obvious, I couldn't find really any hints of it in the GUI) 1) it's of course not there, not sure if it has any consequences: 2) this one goes into an infinite loop (when pressing Apple+c): |
|
@StephanPreibisch The first exception is expected and not a problem. The second one, I have not seen, but @bogovicj has the same. If you don't have it, could you try to |
|
Hi @tpietzsch, I also tried and I am getting some other error: I checked and it is here:
within For the SAC where it crashed it shows: 
Maybe you could change the code such that it does not try to get the color if it does not support colors? Note that this SAC is one that MoBIE builds for a label image, where I don't use the normal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JSON "link" includes viewer transform, color and intensity, visibility, and display mode settings.
Additionally, the link also includes ResourceSpecs for re-creating Sources (or matching existing sources) if they are registered with the new
ResourceManager. (This is already implemented forSpimDatasources in this PR).When copying and pasting links, it is not clear what the user wants:
The approach to this is to copy as much information as possible, and allow the user to configure what to use when pasting.
This can be configured in the Preferences dialog and is saved to a settings YAML file:
In case the user often wants to change the pasting behaviour, this configuration page can also be added to the side panel.
Default shortcuts for copying and pasting are command/ctrl-C and command/ctrl-V, obviously...
