Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storefront): SD-10894 add Karla 700 font weight to schema.json and remove italic versions #2522

Merged
merged 1 commit into from
Dec 18, 2024
Merged

fix(storefront): SD-10894 add Karla 700 font weight to schema.json and remove italic versions #2522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## Draft
- Add Karla 700 font weight to schema.json and remove italic versions [#2522](https://github.com/bigcommerce/cornerstone/pull/2522)
- Fix product filter display name in Show More modal window [#2510](https://github.com/bigcommerce/cornerstone/pull/2510)
- Fix colour value for carousel play-pause button [#2509](https://github.com/bigcommerce/cornerstone/pull/2509)
- Bulk pricing modal on PLP only displays information for the first product [#2501](https://github.com/bigcommerce/cornerstone/pull/2501)
Expand Down
2 changes: 1 addition & 1 deletion config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@
"default_image_brand": "img/BrandDefault.gif",
"default_image_product": "img/ProductDefault.gif",
"default_image_gift_certificate": "img/GiftCertificate.png",
"body-font": "Google_Karla_400,400i,700,700i",
"body-font": "Google_Karla_400",
"headings-font": "Google_Montserrat_400",
"fontSize-root": 14,
"fontSize-h1": 28,
Expand Down
40 changes: 40 additions & 0 deletions schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,11 @@
"label": "i18n.Karla",
"value": "Google_Karla_400"
},
{
"group": "i18n.Karla",
"label": "i18n.KarlaBold",
"value": "Google_Karla_700"
},
{
"group": "i18n.Roboto",
"label": "i18n.Roboto",
Expand Down Expand Up @@ -2242,6 +2247,11 @@
"label": "i18n.Karla",
"value": "Google_Karla_400"
},
{
"group": "i18n.Karla",
"label": "i18n.KarlaBold",
"value": "Google_Karla_700"
},
{
"group": "i18n.Roboto",
"label": "i18n.Roboto",
Expand Down Expand Up @@ -2294,6 +2304,11 @@
"label": "i18n.Karla",
"value": "Google_Karla_400"
},
{
"group": "i18n.Karla",
"label": "i18n.KarlaBold",
"value": "Google_Karla_700"
},
{
"group": "i18n.Roboto",
"label": "i18n.Roboto",
Expand Down Expand Up @@ -2364,6 +2379,11 @@
"label": "i18n.Karla",
"value": "Google_Karla_400"
},
{
"group": "i18n.Karla",
"label": "i18n.KarlaBold",
"value": "Google_Karla_700"
},
{
"group": "i18n.Roboto",
"label": "i18n.Roboto",
Expand Down Expand Up @@ -2416,6 +2436,11 @@
"label": "i18n.Karla",
"value": "Google_Karla_400"
},
{
"group": "i18n.Karla",
"label": "i18n.KarlaBold",
"value": "Google_Karla_700"
},
{
"group": "i18n.Roboto",
"label": "i18n.Roboto",
Expand Down Expand Up @@ -2468,6 +2493,11 @@
"label": "i18n.Karla",
"value": "Google_Karla_400"
},
{
"group": "i18n.Karla",
"label": "i18n.KarlaBold",
"value": "Google_Karla_700"
},
{
"group": "i18n.Roboto",
"label": "i18n.Roboto",
Expand Down Expand Up @@ -2529,6 +2559,11 @@
"label": "i18n.Karla",
"value": "Google_Karla_400"
},
{
"group": "i18n.Karla",
"label": "i18n.KarlaBold",
"value": "Google_Karla_700"
},
{
"group": "i18n.Roboto",
"label": "i18n.Roboto",
Expand Down Expand Up @@ -2640,6 +2675,11 @@
"label": "i18n.Karla",
"value": "Google_Karla_400"
},
{
"group": "i18n.Karla",
"label": "i18n.KarlaBold",
"value": "Google_Karla_700"
},
{
"group": "i18n.Roboto",
"label": "i18n.Roboto",
Expand Down
19 changes: 19 additions & 0 deletions schemaTranslations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,25 @@
"pl": "Karla",
"ja": "Karla"
},
"i18n.KarlaBold": {
"default": "Karla Bold",
"fr": "Karla Bold",
"it": "Karla Bold",
"zh": "Karla Bold",
"de": "Karla Bold",
"es": "Karla Bold",
"nl": "Karla Bold",
"pt": "Karla Bold",
"pt-BR": "Karla Bold",
"sv": "Karla Bold",
"es-MX": "Karla Bold",
"es-419": "Karla Bold",
"da": "Karla Bold",
"no": "Karla Bold",
"ko": "Karla Bold",
"pl": "Karla Bold",
"ja": "Karla Bold"
},
"i18n.Roboto": {
"default": "Roboto",
"fr": "Roboto",
Expand Down
Loading