Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storefront): BCTHEME-1897 Date Field Modifier - February showing 30th and 31st #2473

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

bc-vlad-dlogush
Copy link
Contributor

@bc-vlad-dlogush bc-vlad-dlogush commented Jul 8, 2024

Jira: BCTHEME-1870

What/Why?

This PR fixes an issue with displaying the correct number of days when a specific date is selected

Rollout/Rollback

No Rollout/Rollback

Testing

before.mov
after.2.mov

@bc-vlad-dlogush bc-vlad-dlogush self-assigned this Jul 8, 2024
@bc-vlad-dlogush bc-vlad-dlogush marked this pull request as draft July 8, 2024 11:57
@bc-vlad-dlogush bc-vlad-dlogush force-pushed the BCTHEME-1897 branch 4 times, most recently from f15edaa to edd0fc5 Compare July 9, 2024 07:53
@bc-vlad-dlogush bc-vlad-dlogush force-pushed the BCTHEME-1897 branch 2 times, most recently from 973183d to 3cc37fd Compare July 17, 2024 07:48
@bc-vlad-dlogush bc-vlad-dlogush requested a review from a team July 17, 2024 07:50
@bc-vlad-dlogush bc-vlad-dlogush marked this pull request as ready for review July 17, 2024 07:50
@BC-krasnoshapka BC-krasnoshapka requested a review from a team July 17, 2024 10:28
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@bc-alexsaiannyi bc-alexsaiannyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@bc-vlad-dlogush bc-vlad-dlogush merged commit 97a7605 into master Jul 31, 2024
3 checks passed
@bc-vlad-dlogush bc-vlad-dlogush deleted the BCTHEME-1897 branch July 31, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants