From 11563924d15da3cbaf1b8692c3417e0064eecf48 Mon Sep 17 00:00:00 2001 From: Yevhenii Buliuk <82589781+bc-yevhenii-buliuk@users.noreply.github.com> Date: Tue, 12 Mar 2024 16:01:01 +0200 Subject: [PATCH] fix(storefront): BCTHEME-1768 ADA Compliance - Accordion buttons are not read by screen reader correctly (#2441) --- CHANGELOG.md | 5 +++-- assets/scss/components/foundation/accordion/_accordion.scss | 6 ++++++ .../faceted-search/faceted-search-navigation.html | 4 ++-- 3 files changed, 11 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3f1266de5b..4e608206ca 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,8 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). ## Draft -- Legion requires additional ARIA markup to assist screen reader users [#2435](https://github.com/bigcommerce/cornerstone/pull/2435) -- Page Suggested Items still listed on Cornerstone [#2438](https://github.com/bigcommerce/cornerstone/pull/2438) +- ADA Compliance - Accordion buttons are not read by screen reader correctly [#2441](https://github.com/bigcommerce/cornerstone/pull/2441) +- ADA Compliance - Region requires additional ARIA markup to assist screen reader users [#2435](https://github.com/bigcommerce/cornerstone/pull/2435) - ADA Compliance - Add translations to accessibility attributes for Coupon Code and Gift Certificates [#2440](https://github.com/bigcommerce/cornerstone/pull/2440) - ADA Compliance - The Add to Cart modal dialog container is not labeled [#2427](https://github.com/bigcommerce/cornerstone/pull/2427) - ADA Compliance - Decorative SVG elements should be hidden from screen reader users [#2432](https://github.com/bigcommerce/cornerstone/pull/2432) @@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - ADA Compliance - All form fields must be properly labeled [#2433](https://github.com/bigcommerce/cornerstone/pull/2433) - ADA Compliance - Errors are not identified to screen reader users within the Refine By accordions [#2424](https://github.com/bigcommerce/cornerstone/pull/2424) - ADA Compliance - Expandable items should be read by screen reader [2422](https://github.com/bigcommerce/cornerstone/pull/2422) +- Page Suggested Items still listed on Cornerstone [#2438](https://github.com/bigcommerce/cornerstone/pull/2438) - Remove shop_by_price: true from category.html [#2431](https://github.com/bigcommerce/cornerstone/pull/2431) - Added SEPA and ECP stored bank accounts typesto the Payment methods page [#2434](https://github.com/bigcommerce/cornerstone/pull/2434) diff --git a/assets/scss/components/foundation/accordion/_accordion.scss b/assets/scss/components/foundation/accordion/_accordion.scss index 1c709bf73e..d34b5ff80a 100644 --- a/assets/scss/components/foundation/accordion/_accordion.scss +++ b/assets/scss/components/foundation/accordion/_accordion.scss @@ -62,6 +62,12 @@ } } + .accordion-heading { + font-size: fontSize("base"); + line-height: lineHeight("smaller"); + margin: 0; + } + .accordion-content { padding: $accordion-navList-padding; diff --git a/templates/components/faceted-search/faceted-search-navigation.html b/templates/components/faceted-search/faceted-search-navigation.html index 1bfec71075..06c721a358 100644 --- a/templates/components/faceted-search/faceted-search-navigation.html +++ b/templates/components/faceted-search/faceted-search-navigation.html @@ -1,4 +1,4 @@ -
+

+