fix(json): Validate all JSON fields #2075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2075 +/- ##
==========================================
+ Coverage 85.69% 87.23% +1.53%
==========================================
Files 91 139 +48
Lines 3782 6800 +3018
Branches 1220 1607 +387
==========================================
+ Hits 3241 5932 +2691
- Misses 455 776 +321
- Partials 86 92 +6 ☔ View full report in Codecov by Sentry. |
The JSON validation code strongly assumed it was validating sidecars, not JSON files. These changes streamline the logic a bit to ensure that sidecars and JSON files are treated the same, but the sidecar "origin" code is skipped for JSON files.
effigies
force-pushed
the
fix/json-validation-logic
branch
from
5a6bf6b to
5c82715
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JSON validation code strongly assumed it was validating sidecars, not JSON files. These changes streamline the logic a bit to ensure that sidecars and JSON files are treated the same, but the sidecar "origin" code is skipped for JSON files.
Closes #2007.