Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Typo in reference_frame description (SpatialAxis -> SpatialAxes) #1721

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

yarikoptic
Copy link
Collaborator

Should be plural

❯ git grep SpatialAxes
src/modality-specific-files/motion.md:| SpatialAxes   | RECOMMENDED                                            | [string][] | The coordinate system in which the motion data are to be interpreted. A sequence of characters from the set `{'A', 'P', 'L', 'R', 'S', 'I', '_'}` indicating the direction of each axis. For example `"ARS"` indicates positive values in the X, Y, Z axes are respectively anterior, right, and superior of the origin, while `"PLI"` indicates positive values are posterior, left, and inferior of the origin. The `"_"` character may be used for unused axes. |
src/modality-specific-files/motion.md:        "SpatialAxes": "ALS",
src/schema/objects/columns.yaml:    `RotationOrder`, and `SpatialAxes`, and MAY use `Description` for the specification.
src/schema/objects/metadata.yaml:SpatialAxes:
src/schema/objects/metadata.yaml:  name: SpatialAxes

=== Do not change lines below ===
{
 "chain": [],
 "cmd": "git-sedi SpatialAxis SpatialAxes",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.93%. Comparing base (05f64ed) to head (ea2223f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1721   +/-   ##
=======================================
  Coverage   87.93%   87.93%           
=======================================
  Files          16       16           
  Lines        1351     1351           
=======================================
  Hits         1188     1188           
  Misses        163      163           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies
Copy link
Collaborator

effigies commented Mar 7, 2024

@yarikoptic Do you want this in the changelog? If not, please add the exclude-from-changelog label.

@effigies effigies changed the title Fix typo in SpatialAxes [FIX] Typo in reference_frame description (SpatialAxis -> SpatialAxes) Mar 7, 2024
@yarikoptic yarikoptic added the exclude-from-changelog This item will not feature in the automatically generated changelog label Mar 7, 2024
@effigies effigies merged commit 327bece into bids-standard:master Mar 7, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude-from-changelog This item will not feature in the automatically generated changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants