Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Should subsection "Task events" be under "Modality specific files" as opposed to "Modality agnostic files"? #1868

Closed
oesteban opened this issue Jul 12, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@oesteban
Copy link
Collaborator

Describe your problem in detail.

Tasks files do not seem modality-attached, and it is my experience that finding them under modality-specific is confusing for newcomers, especially those with more training in multimodal behavioral experiments.

Describe what you expected.

I believe tasks description and metadata should better be under modality agnostic.

Stimulus are likely to fall under the same problem.

BIDS specification section

https://bids-specification.readthedocs.io/en/stable/modality-specific-files/task-events.html

@oesteban oesteban added the bug Something isn't working label Jul 12, 2024
@yarikoptic
Copy link
Collaborator

It is already in Modality specific files:
image

May be you meant "the other way"? But it seems that the section names (agnostic vs specific) is merely to separate which files go above <modality>/ (e.g. anat/, func/, etc) folders and which go under, so rather reflect not "specificity" but rather "location"; and presence of _events file is also "modality specific" (i.e. we do not allow it ATM for anat) as coded in https://github.com/bids-standard/bids-specification/blob/HEAD/src/schema/rules/files/raw/task.yaml#L60 making them "modality specific".

But overall I feel that in principle we could

  • remove "Task" from "Task Events" . After all we say

The purpose of this file is to describe timing and other properties of events recorded during a run. Events are, for example, stimuli presented to the participant or participant responses (see Definitions). A single event file MAY include any combination of stimulus, response, and other events

So it could be events not associated with any task! It could be annotation of some events happening during anatomical MRI acquisition (when subject blinked, or wiped nose, or ...).

  • then _events could become applicable to any data file, and thus despite being stored along with data file in modality specific folder, become a modality agnostic file altogether.

Should we change the title? ;-)

@oesteban
Copy link
Collaborator Author

May be you meant "the other way"?

Yes, that's what I meant. Thanks for making it clearer :)

  • remove "Task" from "Task Events" . After all we say

The purpose of this file is to describe timing and other properties of events recorded during a run. Events are, for example, stimuli presented to the participant or participant responses (see Definitions). A single event file MAY include any combination of stimulus, response, and other events

So it could be events not associated with any task! It could be annotation of some events happening during anatomical MRI acquisition (when subject blinked, or wiped nose, or ...).

I don't know the specs with sufficient depth to be sure that we can just remove "Task" from "Task Events". If that is the case I'm +1 on this idea -- it would simplify things so much (e.g., #1751 and #1692 [seems like I'm partially repeating myself, I had forgotten of these when I posted])

Should we change the title? ;-)

Sure -- and also close if you think #1692 and/or #1751 are already covering this.

Thanks for looking into this

@yarikoptic
Copy link
Collaborator

Ha, @VisLab thought alike me on removing "Task" in #1751 (comment) . Indeed I feel like this issue is largely a duplicate of the

so let's try to remember it exists and close this one for now.

@oesteban
Copy link
Collaborator Author

Duplicate of #1751.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants