Make raise_on_notset
default to True
with environment variable override
#3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how the rule engine handles missing fields by making it stricter by default while maintaining flexibility for users who need different behaviour.
Key changes:
_raise_on_notset
to default toTrue
instead ofFalse
RULE_ENGINE_RAISE_ON_NOTSET
to globally control this behavior__raise_on_notset
parameter__raise_on_notset=False
where neededThis change makes the behaviour more explicit and safer by default, as it will now alert users when they try to evaluate rules against missing fields rather than silently failing. Users who need the old behavior can either:
RULE_ENGINE_RAISE_ON_NOTSET=false
globally__raise_on_notset=False
on specific rules