Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of p_o_i and p_o functions #7

Open
franknoe opened this issue Mar 11, 2015 · 2 comments
Open

Get rid of p_o_i and p_o functions #7

franknoe opened this issue Mar 11, 2015 · 2 comments
Assignees

Comments

@franknoe
Copy link
Contributor

I have noticed that I am not using the output_model functions:

bhmm.output_models.discrete.p_o_i
bhmm.output_models.discrete.log_p_o_i
bhmm.output_models.discrete.p_o
bhmm.output_models.discrete.log_p_o
bhmm.output_models.gaussian.p_o_i
bhmm.output_models.gaussian.log_p_o_i
bhmm.output_models.gaussian.p_o
bhmm.output_models.gaussian.log_p_o

In favor of a smaller interface I would like to remove them unless you believe we need them.

@jchodera
Copy link
Contributor

Sounds good! Happy to submit a PR for this once we have fixed the failing nosetests.

@franknoe
Copy link
Contributor Author

I have commented out these functions for now. If we're sure we don't need them, we can remove the code.

@franknoe franknoe reopened this Mar 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants