Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up CachedQueries when Observable has no subscriptions #37

Open
artem-v-shamsutdinov opened this issue Jan 27, 2023 · 0 comments
Open

Clean up CachedQueries when Observable has no subscriptions #37

artem-v-shamsutdinov opened this issue Jan 27, 2023 · 0 comments
Labels
Defect Something isn't working good first issue Good for newcomers

Comments

@artem-v-shamsutdinov
Copy link
Member

Right how Observable queries get added to ActiveQueries and are never cleaned up. They probably need to be cleaned out when the Observable is no longer subscribed to (and when a UI that holds the subscriptions gets unloaded/replaced by another UI). There should be a way to re-add a query to ActiveQueries in case the Observable is still around and can be re-subscribed to.
@artem-v-shamsutdinov artem-v-shamsutdinov added Defect Something isn't working good first issue Good for newcomers labels Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Defect Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@artem-v-shamsutdinov