[Merged by Bors] - fix failing doc test and clear up docs for TaskPool::scope #6314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Objective Alternative to bevyengine#6150 Dependabot's PR doesn't seem to break anything, but there are some deprecations that we might as well fix up. ## Solution https://github.com/clap-rs/clap/blob/master/CHANGELOG.md#migrating Update clap in `build-wasm-example` and `span-cmp`. Other tools don't use clap. Remove references to `value_parser`. It's the default now. Change `#[clap()]` to `#[arg()]`. Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
alice-i-cecile
approved these changes
Oct 20, 2022
alice-i-cecile
added
C-Bug
|
I would prefer to avoid leaving commented code in doc, because it will probably not be updated when the API change. Is it possible to explain the non deterministicness without it? or change the assert so that it doesn't care about the order. |
mockersf
approved these changes
Oct 20, 2022
mockersf
added
the
S-Ready-For-Final-Review
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 20, 2022
# Objective Fixes #6306 ## Solution Change the failing assert and expand example to explain when ordering is deterministic or not. Co-authored-by: Mike Hsu <mike.hsu@gmail.com>
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective Fixes bevyengine#6306 ## Solution Change the failing assert and expand example to explain when ordering is deterministic or not. Co-authored-by: Mike Hsu <mike.hsu@gmail.com>
hymm
changed the title
Pietrek14
pushed a commit
to Pietrek14/bevy
that referenced
this pull request
Dec 17, 2022
# Objective Fixes bevyengine#6306 ## Solution Change the failing assert and expand example to explain when ordering is deterministic or not. Co-authored-by: Mike Hsu <mike.hsu@gmail.com>
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective Fixes bevyengine#6306 ## Solution Change the failing assert and expand example to explain when ordering is deterministic or not. Co-authored-by: Mike Hsu <mike.hsu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #6306
Solution
Change the failing assert and expand example to explain when ordering is deterministic or not.