Make buffer binding arrays emit bind group layout entries and bindless resource descriptors again. #18125
+24
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resource descriptors again. PR bevyengine#17965 mistakenly made the `AsBindGroup` macro no longer emit a bind group layout entry and a resource descriptor for buffers. This commit adds that functionality back, fixing the `shader_material_bindless` example. Closes bevyengine#18124.
pcwalton
added
D-Modest
|
I don't know enough about AsBindGroup to review this, sorry. |
superdump
reviewed
Mar 3, 2025
| @@ -161,6 +161,29 @@ pub fn derive_as_bind_group(ast: syn::DeriveInput) -> Result<TokenStream> { | |||
| } | |||
| _ => {} | |||
| } | |||
|
|
|||
| let binding_array_binding = binding_array_binding.unwrap_or(0); | |||
There was a problem hiding this comment.
0? Why is 0 implicitly correct? I thought the data is automatically serialised into a buffer at binding 0?
There was a problem hiding this comment.
It's not. I just need a dummy value to insert into bindless_binding_layouts, because we populate that array anyway even in the non-bindless case, for simplicity. Maybe that should be refactored though. (This macro is a mess in general, unfortunately.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #17965 mistakenly made the
AsBindGroupmacro no longer emit a bind group layout entry and a resource descriptor for buffers. This commit adds that functionality back, fixing theshader_material_bindlessexample.Closes #18124.