Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update compile fail test stderr files #18056

Merged
merged 1 commit into from
Mar 1, 2025

Conversation

RobWalt
Copy link
Contributor

@RobWalt RobWalt commented Feb 26, 2025

I noticed this while working on #18017 . Some of the stderr compile_fail tests were updated while I generated the output for the new tests I introduced in the mentioned PR.

I'm on rust 1.85.0

Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why CI wasn't catching these...

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior C-Testing A change that impacts how we test Bevy or how users test their apps A-Cross-Cutting Impacts the entire engine S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Feb 26, 2025
@mockersf
Copy link
Member

if CI didn't fail on that before, it means CI wasn't running them. Could you manage to get CI to fail before fixing them?

@RobWalt
Copy link
Contributor Author

RobWalt commented Feb 26, 2025

if CI didn't fail on that before, it means CI wasn't running them. Could you manage to get CI to fail before fixing them?

Nope doesn't seem like it was failing although it was clearly broken prior to b452c92

@Brezak
Copy link
Contributor

Brezak commented Feb 26, 2025

if CI didn't fail on that before, it means CI wasn't running them. Could you manage to get CI to fail before fixing them?

We ignore differences between the stderr output of compile fail tests. When testing derive macros the backtrace would leak the location of the developers .cargo directory. I tried to filter the paths out but the filter would break randomly.

I seem to remember reading somewhere that rust now strips the path to .cargo in errors. I'll check tomorrow and if yes we can enable comparing the stderr output again.

@Brezak Brezak mentioned this pull request Feb 27, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Mar 1, 2025
Merged via the queue into bevyengine:main with commit 73ffd9a Mar 1, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Cross-Cutting Impacts the entire engine C-Bug An unexpected or incorrect behavior C-Testing A change that impacts how we test Bevy or how users test their apps S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants