Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

moved Debug from derive to impl_ptr in bevy_ptr #18042

Merged
merged 3 commits into from
Feb 28, 2025
Merged

moved Debug from derive to impl_ptr in bevy_ptr #18042

merged 3 commits into from
Feb 28, 2025

Conversation

mysteriouslyseeing
Copy link
Contributor

Objective

Fixes #17988

Solution

Added two Debug impls to the impl_ptr macro - one for Aligned and one for Unaligned.

Testing

No tests have been added. Would a test guaranteeing debug layout be appropriate?

Showcase

The debug representation of a Ptr<'_, Aligned> follows. PtrMut and OwningPtr are similar.

Ptr<Aligned>(0x0123456789ab)

@github-actions GitHub Actions
Copy link
Contributor

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

@alice-i-cecile alice-i-cecile added C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Pointers Relating to Bevy pointer abstractions D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels Feb 26, 2025
@alice-i-cecile alice-i-cecile added S-Needs-Review Needs reviewer attention (from anyone!) to move forward and removed S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels Feb 27, 2025
@mysteriouslyseeing mysteriouslyseeing mentioned this pull request Feb 28, 2025
Closed
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Feb 28, 2025
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Feb 28, 2025
Merged via the queue into bevyengine:main with commit e43b28c Feb 28, 2025
32 checks passed
@mysteriouslyseeing mysteriouslyseeing deleted the bevy_ptr_debug branch February 28, 2025 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@MrGVSV MrGVSV MrGVSV approved these changes

Assignees
No one assigned
Labels
A-Pointers Relating to Bevy pointer abstractions C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change #[derive(Debug)] to manual impl for certain bevy_ptr types
3 participants
@mysteriouslyseeing @alice-i-cecile @MrGVSV