Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optional futures dependency #73

Open
Tropix126 opened this issue Jul 12, 2024 · 0 comments · May be fixed by #81
Open

optional futures dependency #73

Tropix126 opened this issue Jul 12, 2024 · 0 comments · May be fixed by #81

Comments

@Tropix126
Copy link

Hi! Would it be possible to modify tokio_serial to specify futures as an optional dependency? It seem to only be used in two places -- once in the unix prelude and another time in the framed serial stream implementation which is already an optional feature.

I don't really personally have a usecase for the framed stream implementation, but the full futures crate with all features is still brought in as a dependency despite being unused (except in that prelude). Is there anything that can be done about this? I'd be glad to contribute a patch, but i'm not sure the importance of re-exporting futures::ready in the unix prelude.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant