-
Notifications
You must be signed in to change notification settings - Fork 10
/
Copy pathexceptions.txt
288 lines (279 loc) · 8.84 KB
/
exceptions.txt
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
<div dir="ltr" style="text-align: left;" trbidi="on">
Íè äëÿ êîãî íàâåðíîå íå îòêðîþ Àìåðèêó, íî âñ¸ æå íàïèøó.<br />
<br />
Ìîæíî ñäåëàòü òàê:<br />
<br />
<pre class="brush:delphi">type
EmyException = class(Exception)
end;//EmyException
...
if not Condition1 then
raise EMyException.Create('Some string1');
...
if not Condition2 then
raise EMyException.Create('Some string2');
</pre>
<br />
À ìîæíî òàê:
<br />
<br />
<pre class="brush:delphi">type
EmyException = class(Exception)
public
class procedure Check(aCondition: Boolean;
const aMessage: String);
end;//EmyException
...
class procedure EmyException.Check(aCondition: Boolean;
const aMessage: String);
begin
if not aCondition then
raise Self.Create(aMessage);
end;
...
EMyException.Check(Condition1, 'Some string1');
...
EMyException.Check(Condition2, 'Some string2');
</pre>
<br />
Âðîäå "òî æå íà òî æå", è îáà âàðèàíòà - îäèíàêîâûå.
<br />
<br />
Íî ïî ìíå - âòîðîé âàðèàíò - "âêóñíåå". Äà è ÷èòàáåëüíåå.<br />
<br />
È â îòëàäêå - ïîëåçíåå.<br />
<br />
Ïî÷åìó â îòëàäêå ïîëåçíåå? Ïîòîìó, ÷òî ìîæíî ïîñòàâèòü <b>îäèí</b> break-point â EmyException.Check, à íå ìíîæåñòâî ïî êîäó.<br />
<br />
Âîçìîæíî â íîâûõ âåðñèÿõ Delphi ýòî âõîäèò â ñòàíäàðòíóþ áèáëèîòåêó. Íå çíàþ, ÷åñòíî - íå ïðîâåðÿë. Íî ìû ýòèì ïîäõîäîì ïîëüçóåìñÿ óæå <b>î÷åíü äàâíî</b>. È îí íàì íðàâèòñÿ.<br />
<br />
È åãî ïîíÿòíîå äåëî - ìîæíî ðàñøèðÿòü è óñîâåðøåíñòâîâàòü.<br />
<br />
Íàïðèìåð - íå ïåðåäàâàòü ñòðîêó, à "ãåíåðèðîâàòü" å¸ âíóòðè Check. Íó â îáùåì - âàðèàíòîâ ìàññà.<br />
<br />
Íó è åù¸ îòìå÷ó - ÿ íàáëþäàë äîñòàòî÷íîå êîëè÷åñòâî ëþäåé, êîòîðûå çàáûâàëè raise.<br />
<br />
Ò.å. ïèñàëè òàê:<br />
<br />
<pre class="brush:delphi"> Exception.Create('aMessage');
</pre>
<br />
à íå òàê:
<br />
<br />
<pre class="brush:delphi"> raise Exception.Create('aMessage');
</pre>
<br />
Íó è ïðî "ðàñøèðåíèÿ".<br />
<br />
Ìîæíî íàïðèìåð òàê:
<br />
<br />
<pre class="brush:delphi">type
TMyPredicate = reference to function (aData: Integer): Boolean;
EmyException = class(Exception)
public
class procedure Check(aCondition: Boolean;
const aMessage: String); overload;
class procedure Check(aCondition: TMyPredicate;
const aMessage: String;
aData: Integer); overload;
end;//EmyException
...
class procedure EmyException.Check(aCondition: Boolean;
const aMessage: String);
begin
if not aCondition then
raise Self.Create(aMessage);
end;
class procedure EmyException.Check(aCondition: TMyPredicate;
const aMessage: String;
aData: Integer);
begin
if not aCondition(aData) then
raise Self.Create('InvalidData: ' + IntToStr(aData) + aMessage);
end;
...
EMyException.Check(Condition1, 'Some string1');
...
EMyException.Check(
function (aData: Integer): Boolean;
begin
Result := IsValid(aData);
end;,
'Some string2',
SomeComplexExpression);
</pre>
<br />
-- íó ïîíÿòíîå, äåëî, ÷òî ýòî "ìàêåò", à íå ðåàëüíî ðàáî÷èé êîä.
<br />
<br />
×åì ýòîò "ìàêåò" õîðîø? Òåì, ÷òî SomeComplexExpression - âû÷èñëèòñÿ <b>îäèí</b> ðàç.<br />
<br />
Ïîíÿòíîå äåëî, ÷òî ìîæíî è "ëîêàëüíîé ïåðåìåííîé" îáîéòèñü.<br />
Íó ýòî â ïðîñòåéøèõ ñëó÷àÿõ.
<br />
<br />
Äà è ïîòîì, âåäü ìîæíî íàïèñàòü è òàê:
<br />
<br />
<pre class="brush:delphi">var
SomeLocalData : Integer;
EMyException.Check(
function (aData: Integer): Boolean;
begin
Result := (aData = SomeLocalData);
end;,
'Some string2',
SomeComplexExpression);
</pre>
<br />
Update.
<br />
<br />
Ïî ìîòèâàì êîììåíòàðèÿ - <a href="http://programmingmindstream.blogspot.ru/2014/08/blog-post_85.html?showComment=1408566592655#c1216957169742679866">http://programmingmindstream.blogspot.ru/2014/08/blog-post_85.html?showComment=1408566592655#c1216957169742679866</a><br />
<br />
Ïðî "ïðîñòî ïðîöåäóðó" - ìû êîíå÷íî æå òîæå èìè ïîëüçîâàëèñü:
<br />
<br />
<pre class="brush:delphi">function Ht(ID : LongInt) : LongInt;
{var
nDosError : SmallInt; // Ñþäà çàíåñóò êîä, âîçâðàùåííûé ÄÎÑ
nOperation: SmallInt; // Ñþäà çàíåñóò êîä îïåðàöèè, ïðèâåäøåé ê îøèáêå
lErrstr : array[0..1000] of AnsiChar;
lErrstr2 : PAnsiChar;
}
begin
Result := ID;
if lNeedStackOut_ErrNum <> 0 then
begin
l3System.Stack2Log(Format('HTERROR = %d STACK OUT', [lNeedStackOut_ErrNum]));
lNeedStackOut_ErrNum := 0;
end;
{ if ID = -1 then
lErrstr2 := htExtError(nDosError, nOperation, @lErrstr[0]);
}
if ID < 0 then
raise EHtErrors.CreateInt(ID);
end;
....
Ht(htOpenResults(Masks,ROPEN_READ,@FldArr,FldCount));
....
Ht(htDeleteRecords(TmpList));
....
Ht(htOpenResults(ValList,ROPEN_READ,nil,0));
</pre>
<br />
È åù¸.<br />
<br />
×òî ñëó÷èòñÿ, åñëè ìû íàïèøåì òàê:
<br />
<br />
<pre class="brush:delphi">type
EmyException2 = class(EmyException)
end;//EmyException2
...
EmyException2.Check(aCondition, aMessage);
</pre>
<br />
-- èñêëþ÷åíèå êàêîãî êëàññà âîçáóäèòñÿ?<br />
<br />
EmyException èëè EmyException2?<br />
<br />
EmyException2 :-) ÷òî è "ñëåäîâàëî îæèäàòü".<br />
<br />
Ýòî ê âîïðîñó - "ïî÷åìó ìåòîä êëàññà, à íå ïðîñòî ôóíêöèÿ".<br />
<br />
Update.<br />
<br />
(Â íåêîòîðîì ðîäå â îòâåò íà - http://programmingmindstream.blogspot.ru/2014/08/blog-post_85.html?showComment=1408649403323#c8271514992700352647)<br />
<br />
Âîò êñòàòè ïðèìåð, òîãî ÷òî íàïèñàíî â ñàìîì íà÷àëå:
<br />
<br />
<pre class="brush:delphi">Em3InvalidStreamPos.Check(Self.IsValidPosition,
aHeader.f_Name,
l_Pos);
Em3InvalidStreamSize.Check(Self.IsValidPosition,
aHeader.f_Name,
aHeader.f_TOCItemData.rBody.rRealSize);
Em3InvalidStreamPos.Check(Self.IsValidLink,
aHeader.f_Name,
aHeader.f_TOCItemData.rBody.RTOCBuffRootPosition);
Em3InvalidStreamPos.Check(Self.IsValidLink,
aHeader.f_Name,
aHeader.f_TOCItemData.rBody.RTOCItemListPosition);
Em3InvalidStreamPos.Check(Self.IsValidLink,
aHeader.f_Name,
aHeader.f_TOCItemData.RNextPosition);
</pre>
<br />
- IsValidPosition è IsValidLink ýòî ïðåäèêàòû.<br />
<br />
Ò.å. function (aData: Int64): Boolean of object;<br />
<br />
Check â äàííîì ñëó÷àå âûãëÿäèò òàê:
<br />
<br />
<pre class="brush:delphi">type
TInt64Predicate = function (aData: Int64): Boolean of object;
...
class procedure Em3InvalidStreamData.Check(aCondition: TInt64Predicate;
aName : String;
aData : Int64);
begin
if not aCondition(aData) then
raise Self.CreateFmt('Invalid data %d in file %s', [aName, aData]);
end;
...
Em3InvalidStreamPos = class(Em3InvalidStreamData);
Em3InvalidStreamSize = class(Em3InvalidStreamData);
</pre>
<br />
-- çà÷åì åù¸ ýòî íóæíî?<br />
<br />
Íó ÷òîáû ñ ôîðìàòêàìè â ôóíêöèè Format íå íàïóòàòü.
<br />
<br />
È íå îòëàæèâàòü "íàâåä¸ííûé" exception êîòîðûé âûëåçåò ó ïîëüçîâàòåëÿ, íî "íå ðàññêàæåò ïðàâäó".<br />
<br />
Ïîíÿòíîå äåëî, ÷òî ïðèìåð êîäà - äàëåêî íå ñàìûé "êðàñèâûé", íî ÿ ñïåöèàëüíî íè÷åãî íå ðàôèíèðîâàë.<br />
<br />
Êîíå÷íî - íà âêóñ è öâåò - "âñå ôëîìàñòåðû ðàçíûå", íî ìíå ëè÷íî ýòî íðàâèòñÿ áîëüøå, ÷åì ñ "âÿçàíêîé" raise.<br />
<br />
Ïîïðîáóéòå íàïèñàòü ñ raise è ïîêàæèòå - ÷òî îí "áóäåò êîðî÷å". ß áóäó ðàä ïîó÷èòüñÿ.<br />
<br />
È êñòàòè äà - âûâîä ñòåêà â ëîã - ïîìîãàåò èäåíòèôèöèðîâàòü ñòðîêó - îòêóäà ïîëåòåëî èñêëþ÷åíèå. Íî ïðî ýòî ÿ ìîæåò áûòü åù¸ êîãäà-íèáóäü íàïèøó îòäåëüíî. <br />
<br />
(Ïîêà âîò <a href="http://programmingmindstream.blogspot.ru/2014/08/blog-post_22.html">òóò</a> - èä¸ò íåêîòîðàÿ äèñêóññèÿ)<br />
<br />
Update.<br />
<br />
Äà è îãîâîðþñü.<br />
<br />
Ìîæíî áûëî áû êîíå÷íî "ñî÷èíèòü" ÷òî-òî âðîäå:
<br />
<br />
<pre class="brush:delphi">Em3InvalidStreamPos.Check(Self.IsValidPosition,
aHeader.f_Name,
[l_Pos,
aHeader.f_TOCItemData.rBody.rRealSize,
aHeader.f_TOCItemData.rBody.RTOCBuffRootPosition,
aHeader.f_TOCItemData.rBody.RTOCItemListPosition,
aHeader.f_TOCItemData.RNextPosition]);
</pre>
<br />
-- íî ÿ <b>îñîçíàííî</b> ýòîãî íå äåëàþ.<br />
<br />
Ò.ê. êîíå÷íî çàïèñü êîðî÷å è "÷èòàáåëüíåå".
<br />
<br />
Íî!  òàêîì âàðèàíòå - ñëîæíåå èñêàòü <b>ðåàëüíûé</b> èñòî÷íèê îøèáêè.<br />
<br />
Íó è <b>with</b> êîíå÷íî òîæå ìîæíî áûëî áû íàïèñàòü. ß çíàþ. Íî <b>ÿ ëè÷íî</b> - "èäåîëîãè÷åñêèé ïðîòèâíèê" with.<br />
<br />
Îñîáåííî â âàðèàíòå Delphi, ãäå íåò "îáðàòíîé óñòîé÷èâîñòè".<br />
<br />
Ñëîâà "îáðàòíàÿ óñòîé÷èâîñòü" ïîíÿòíû? Èëè ÿ îïÿòü "âûäóìûâàþ ñâîè òåðìèíû"?<br />
<br />
Íà âñÿêèé ñëó÷àé íàïèñàë âîò ÷òî - <a href="http://programmingmindstream.blogspot.ru/2014/08/blog-post_17.html">Êîðîòêî. Îá "îáðàòíîé óñòîé÷èâîñòè"</a></div>