Fix function last line do not saved in pc2line table issue #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pc2line table only saves the diff between lines, so the function end next line is needed to generate the function's last line diff, the previous code missed it. This patch fixed it by change the line number generate logic a bit. This bug is found on https://github.com/koush/quickjs, an unofficial debugger implementation, push it to the upstream. Signed-off-by: pengyaozong <pengyaozong@xiaomi.com>
|
HarlonWang
added a commit
to HarlonWang/quickjs
that referenced
this pull request
Mar 21, 2023
|
I am not sure the patch is really needed. Without a precise example I won't look at it. |
|
这是来自QQ邮箱的假期自动回复邮件。
您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pc2line table only saves the diff between lines, so the function end
next line is needed to generate the function's last line diff, the
previous code missed it.
This patch fixed it by change the line number generate logic a bit.
This bug is found on https://github.com/koush/quickjs, an unofficial
debugger implementation, push it to the upstream.
Signed-off-by: pengyaozong pengyaozong@xiaomi.com