Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing the service is too slow #47

Closed
Ivan-Perez opened this issue Oct 6, 2017 · 4 comments
Closed

Closing the service is too slow #47

Ivan-Perez opened this issue Oct 6, 2017 · 4 comments

Comments

@Ivan-Perez
Copy link

Hi,

It takes about 10 seconds to get the promise's result from the close() method. Why is it so slow? What is it really doing when closing the service?

Thanks!

@becvert
Copy link
Owner

becvert commented Oct 7, 2017

Android? could it be jmdns/jmdns#82

@becvert
Copy link
Owner

becvert commented Oct 13, 2017

Please upgrade to 1.2.8 and let me know if it's better

@Ivan-Perez
Copy link
Author

Ivan-Perez commented Oct 19, 2017

Yes, it was Android.

After upgrading to 1.2.8 it works faster, now it takes about 4 seconds. I don't know if it can be improved, but anyway, it's something better.

I'm marking this issue as closed as it's related to jmDNS, not with this project itself. Since Android 4.1 (API 16) there is support for mDNS natively (https://developer.android.com/training/connect-devices-wirelessly/nsd.html), so no need to use the jmDNS library. Have you considered it? Ionic 2 by default seem to use API 16 as min SDK.

Thanks!

@becvert
Copy link
Owner

becvert commented Oct 19, 2017

#7 about NSD. It isn't full featured as JmDNS so I stick with it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants