Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AvatarRoot API: Non-VRChat avatar support in VRCSDK projects #71

Closed
wants to merge 9 commits into from

add TODO comment

976dc74
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Closed

AvatarRoot API: Non-VRChat avatar support in VRCSDK projects #71

add TODO comment
976dc74
Select commit
Loading
Failed to load commit list.
GitHub Actions / Test Results completed Sep 29, 2024 in 0s

❌️ Test Results - 46/48, failed: 2 - Failed in 4.630s

❌️ editmode-results.xml - 46/48, failed: 2 - Failed in 4.630s

Details

❌️ editmode-results.xml - 46/48, failed: 2 - Failed in 4.630s
  • ✅ UnitTests.AvatarNameFilterTests - 1/1 - Passed in 0.016s
    • ✅ TestAvatarNameFilter - Passed in 0.016s
  • ❌️ UnitTests.AvatarRootTests.AvatarRoot - 2/4, failed: 2 - Failed in 0.085s

    • ❌️ TestGenericContainsGeneric - Failed in 0.062s
      Expected: False
      But was: True

        at UnitTests.AvatarRootTests.AvatarRoot.NoAvatars () [0x00001] in ./Packages/nadena.dev.ndmf/UnitTests/AvatarRootTests/AvatarRoot.cs:20
at UnitTests.AvatarRootTests.AvatarRoot.TestGenericContainsGeneric () [0x0003f] in ./Packages/nadena.dev.ndmf/UnitTests/AvatarRootTests/AvatarRoot.cs:63

    • ❌️ TestGenericContainsVRC - Failed in 0.008s
      Expected: False
      But was: True

        at UnitTests.AvatarRootTests.AvatarRoot.ChildIsAvatar () [0x00001] in ./Packages/nadena.dev.ndmf/UnitTests/AvatarRootTests/AvatarRoot.cs:38
at UnitTests.AvatarRootTests.AvatarRoot.TestGenericContainsVRC () [0x0003f] in ./Packages/nadena.dev.ndmf/UnitTests/AvatarRootTests/AvatarRoot.cs:79

    • ✅ TestVRCContainsGeneric - Passed in 0.010s

    • ✅ TestVRCContainsVRC - Passed in 0.005s

  • ✅ UnitTests.BuildAssetBundle - 1/1 - Passed in 3.656s
    • ✅ Build - Passed in 3.656s
  • ✅ UnitTests.EditorTests.PublishedValueTest - 3/3 - Passed in 0.022s
    • ✅ BasicObserve - Passed in 0.014s
    • ✅ ObserveWithExtract - Passed in 0.004s
    • ✅ ObserveWithExtractAndEquals - Passed in 0.003s
  • ✅ UnitTests.EditorTests.ShadowHierarchyTest - 15/15 - Passed in 0.267s
    • ✅ ComponentChangeNotification_FiredAfterReorderEvent - Passed in 0.011s
    • ✅ ComponentChangeNotifications_FiredAfterReparents - Passed in 0.004s
    • ✅ ComponentChangeNotifications_GeneratedWhenChildChanges - Passed in 0.004s
    • ✅ ComponentChangeNotifications_GeneratedWhenObjectItselfChanges - Passed in 0.003s
    • ✅ ComponentMonitoringTest - Passed in 0.006s
    • ✅ ComponentReorder_TriggersStructureChange - Passed in 0.006s
    • ✅ ListenerDeregisteredAfterTrueReturn - Passed in 0.004s
    • ✅ OnDestroy_NotificationsBlasted - Passed in 0.004s
    • ✅ OnInvalidateAll_EverythingIsInvalidated - Passed in 0.004s
    • ✅ OnReparentDestroyedObject_NotificationsBlasted - Passed in 0.003s
    • ✅ PathNotifications_GeneratedWhenGrandparentChanged - Passed in 0.004s
    • ✅ PathNotifications_GeneratedWhenImmediateParentChanged - Passed in 0.004s
    • ✅ TestBasic - Passed in 0.003s
    • ✅ WhenDisposed_ListenerIsRemoved - Passed in 0.003s
    • ✅ WhenTargetGCd_ListenerIsRemoved - Passed in 0.202s
  • ✅ UnitTests.ExportsPluginTest.SupportsMultipleDeclarations - 1/1 - Passed in 0.015s
    • ✅ TestSupportsMultipleDeclarations - Passed in 0.015s
  • ✅ UnitTests.InlineErrorTests - 2/2 - Passed in 0.014s
    • ✅ TestEnumerableExpansion - Passed in 0.011s
    • ✅ TestInlineError - Passed in 0.002s
  • ✅ UnitTests.LocalizationFallback.LocalizationFallbackTest - 1/1 - Passed in 0.004s
    • ✅ TestLanguageSelection - Passed in 0.004s
  • ✅ UnitTests.NodeControllerTest - 1/1 - Passed in 0.033s
    • ✅ TestObjectRegistryProcessing - Passed in 0.033s
  • ✅ UnitTests.Parameters.InheritanceTest - 3/3 - Passed in 0.025s
    • ✅ DoesNotResolveAmbiguous - Passed in 0.015s
    • ✅ ResolvesByDepth - Passed in 0.006s
    • ✅ ResolvesInterface - Passed in 0.005s
  • ✅ UnitTests.Parameters.ParameterIntrospectionTest - 7/7 - Passed in 0.184s
    • ✅ DefaultValueMerge - Passed in 0.034s
    • ✅ EditorOnly - Passed in 0.007s
    • ✅ ForBuildContext - Passed in 0.070s
    • ✅ SimpleRemap - Passed in 0.021s
    • ✅ SimpleUsage - Passed in 0.007s
    • ✅ TestEmpty - Passed in 0.006s
    • ✅ TypeMerge - Passed in 0.038s
  • ✅ UnitTests.Parameters.VRChatBindingsTest.TestContact - 3/3 - Passed in 0.026s
    • ✅ TestContact(Constant,Bool) - Passed in 0.014s
    • ✅ TestContact(OnEnter,Bool) - Passed in 0.006s
    • ✅ TestContact(Proximity,Float) - Passed in 0.006s
  • ✅ UnitTests.Parameters.VRChatBindingsTest - 2/2 - Passed in 0.021s
    • ✅ TestPhysBone - Passed in 0.008s
    • ✅ VRCParams - Passed in 0.014s
  • ✅ UnitTests.PluginResolverTests.BeforeAfterPlugin - 1/1 - Passed in 0.008s
    • ✅ TestBeforeAfterPluginConstraints - Passed in 0.008s
  • ✅ UnitTests.SerializationSweepTest - 1/1 - Passed in 0.102s
    • ✅ testSerialization - Passed in 0.102s
  • ✅ UnitTests.TopoSortTest - 2/2 - Passed in 0.020s
    • ✅ StrongSequencingTest - Passed in 0.013s
    • ✅ WeakOrderingTest - Passed in 0.008s

Annotations

Check failure on line 20 in ./Packages/nadena.dev.ndmf/UnitTests/AvatarRootTests/AvatarRoot.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results

UnitTests.AvatarRootTests.AvatarRoot.TestGenericContainsGeneric 

  Expected: False
  But was:  True
Raw output 
at UnitTests.AvatarRootTests.AvatarRoot.NoAvatars () [0x00001] in ./Packages/nadena.dev.ndmf/UnitTests/AvatarRootTests/AvatarRoot.cs:20
at UnitTests.AvatarRootTests.AvatarRoot.TestGenericContainsGeneric () [0x0003f] in ./Packages/nadena.dev.ndmf/UnitTests/AvatarRootTests/AvatarRoot.cs:63

Check failure on line 38 in ./Packages/nadena.dev.ndmf/UnitTests/AvatarRootTests/AvatarRoot.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results

UnitTests.AvatarRootTests.AvatarRoot.TestGenericContainsVRC 

  Expected: False
  But was:  True
Raw output 
at UnitTests.AvatarRootTests.AvatarRoot.ChildIsAvatar () [0x00001] in ./Packages/nadena.dev.ndmf/UnitTests/AvatarRootTests/AvatarRoot.cs:38
at UnitTests.AvatarRootTests.AvatarRoot.TestGenericContainsVRC () [0x0003f] in ./Packages/nadena.dev.ndmf/UnitTests/AvatarRootTests/AvatarRoot.cs:79
View more details on GitHub Actions