fix: minor bugs in preview system (#281)

bdunderscore · Jul 2, 2024 · fc28310 · fc28310
1 parent d8cb15a
commit fc28310
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/Editor/ChangeStream/ListenerSet.cs b/Editor/ChangeStream/ListenerSet.cs
@@ -54,10 +54,17 @@ internal void MaybeFire(T info)
             else if (_filter(info))
             {
                 ctx.Invalidate();
-                EditorApplication.delayCall += SceneView.RepaintAll;
+                // We need to wait two frames before repainting: One to process task callbacks, then one to actually
+                // repaint (and update previews).
+                EditorApplication.delayCall += Delay2Repaint;
                 Dispose();
             }
         }
+
+        private void Delay2Repaint()
+        {
+            EditorApplication.delayCall += SceneView.RepaintAll;
+        }
     }
 
     internal class ListenerSet<T>

diff --git a/Editor/ChangeStream/ObjectWatcher.cs b/Editor/ChangeStream/ObjectWatcher.cs
@@ -186,6 +186,8 @@ public R MonitorObjectProps<T, R>(T obj, ComputeContext ctx, Func<T, R> extract,
 
                 if (usePropMonitor)
                 {
+                    if (obj is Component c && c.gameObject.hideFlags != 0) return curVal;
+
                     var propsListeners = PropertyMonitor.MonitorObjectProps(obj);
                     propsListeners.Register(_ => obj == null || !compare(curVal, extract(obj)), ctx);