fix: prevent creation of overlapping render groups

This generally is unintended and can result in horrible performance issues, so block it entirely.
bdunderscore · Sep 1, 2024 · d588f1d · d588f1d
1 parent 2dfa2a1
commit d588f1d
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -16,6 +16,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - [#363] Reduce GC pressure caused by `ComputeContext.GetComponent`
 
 ### Changed
+- [#364] Prevent creation of overlapping render groups in the same `IRenderFilter`
 
 ### Removed
 

diff --git a/Editor/PreviewSystem/Rendering/TargetSet.cs b/Editor/PreviewSystem/Rendering/TargetSet.cs
@@ -40,6 +40,17 @@ public TargetSet(ImmutableList<IRenderFilter> filters)
                     var groups = filter.GetTargetGroups(_targetSetContext);
                     Profiler.EndSample();
                     if (groups.IsEmpty) continue;
+
+                    var duplicateRenderers = groups.SelectMany(g => g.Renderers)
+                        .GroupBy(r => r)
+                        .FirstOrDefault(agg => agg.Count() > 1);
+                    if (duplicateRenderers != null)
+                    {
+                        Debug.LogError("[" + filter + "] Duplicate renderer " + duplicateRenderers.Key +
+                                       " in groups: " + string.Join(", ", groups));
+                        // Suppress this filter
+                        continue;
+                    }
 
                     builder.Add(new Stage
                     {