chore: use subscenes instead of harmony hacks to hide preview objects (…

…#330)
bdunderscore · Aug 18, 2024 · 999dc53 · 999dc53
1 parent 702ace6
commit 999dc53
Show file tree

Hide file tree

Showing 13 changed files with 314 additions and 256 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,6 +9,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Added
 
+- [#330] `NDMFPreviewSceneManager` added, allowing other libraries to easily hide temporary objects.
+
 ### Fixed
 - [#320] Render nodes are not correctly reused across frames
 - [#321] Fix GetTargetGroup being called on every pipeline invalidation
@@ -18,6 +20,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed
 
+- [#330] Preview objects are now hidden by placing them in a hidden subscene, instead of harmony patching the hierarchy.
+  This should improve stability in general.
+
 ### Removed
 
 ### Security

diff --git a/Editor/MiscDebugTools.cs b/Editor/MiscDebugTools.cs
@@ -0,0 +1,19 @@
+using UnityEditor;
+using UnityEngine;
+using UnityEngine.SceneManagement;
+
+namespace nadena.dev.ndmf.ui
+{
+    internal static class MiscDebugTools
+    {
+        [MenuItem("Tools/NDM Framework/Debug Tools/Dump Scenes")]
+        public static void DumpScenes()
+        {
+            for (var i = 0; i < SceneManager.sceneCount; i++)
+            {
+                var scene = SceneManager.GetSceneAt(i);
+                Debug.Log($"Scene {i}: {scene.name}");
+            }
+        }
+    }
+}
diff --git a/Editor/MiscDebugTools.cs.meta b/Editor/MiscDebugTools.cs.meta
diff --git a/Editor/PreviewSystem/Harmony/HierarchyViewPatches.cs b/Editor/PreviewSystem/Harmony/HierarchyViewPatches.cs
diff --git a/Editor/PreviewSystem/Harmony/HierarchyViewPatches.cs.meta b/Editor/PreviewSystem/Harmony/HierarchyViewPatches.cs.meta
diff --git a/Editor/PreviewSystem/Harmony/Patcher.cs b/Editor/PreviewSystem/Harmony/Patcher.cs
@@ -15,7 +15,7 @@ internal sealed class PatchLoader
         {
             HandleUtilityPatches.Patch_FilterInstanceIDs,
             PickingObjectPatch.Patch,
-            HierarchyViewPatches.Patch
+            //HierarchyViewPatches.Patch
         };
 
         [InitializeOnLoadMethod]