BugFix: Delay options filed improved.

- CD-346
bdecentgmbh · Jan 6, 2025 · d97900a · d97900a
1 parent 36e7f66
commit d97900a
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 5 deletions.
diff --git a/classes/form/general_element_form.php b/classes/form/general_element_form.php
@@ -185,7 +185,7 @@ public function standard_element_settings($mform) {
         $mform->setDefault('duration', $default ?: 'slow');
 
         $mform->addElement('text', 'delay', get_string('strdelay', 'mod_contentdesigner'));
-        $mform->setType('delay', PARAM_INT);
+        $mform->setType('delay', PARAM_TEXT);
         $mform->addHelpButton('delay', 'strdelay', 'mod_contentdesigner');
         $default = get_config('mod_contentdesigner', 'delay');
         $mform->setDefault('delay', $default ?: '');

diff --git a/db/install.xml b/db/install.xml
@@ -57,7 +57,7 @@
         <FIELD NAME="belowcolorbg" TYPE="char" LENGTH="100" NOTNULL="false" SEQUENCE="false"/>
         <FIELD NAME="animation" TYPE="char" LENGTH="30" NOTNULL="false" SEQUENCE="false"/>
         <FIELD NAME="duration" TYPE="char" LENGTH="30" NOTNULL="false" SEQUENCE="false"/>
-        <FIELD NAME="delay" TYPE="int" LENGTH="18" NOTNULL="true" DEFAULT="0" SEQUENCE="false"/>
+        <FIELD NAME="delay" TYPE="char" LENGTH="10" NOTNULL="true" DEFAULT="0" SEQUENCE="false"/>
         <FIELD NAME="direction" TYPE="char" LENGTH="30" NOTNULL="false" SEQUENCE="false"/>
         <FIELD NAME="speed" TYPE="int" LENGTH="9" NOTNULL="true" DEFAULT="0" SEQUENCE="false"/>
         <FIELD NAME="viewport" TYPE="char" LENGTH="30" NOTNULL="false" SEQUENCE="false"/>

diff --git a/db/upgrade.php b/db/upgrade.php
@@ -33,7 +33,20 @@
  * @return bool True on success.
  */
 function xmldb_contentdesigner_upgrade($oldversion) {
-    // Automatically generated Moodle v4.4.0 release upgrade line.
-    // Put any upgrade step following this.
+    global $DB;
+
+    $dbman = $DB->get_manager();
+
+    if ($oldversion < 2024110807) {
+        $optionstable = new xmldb_table('contentdesigner_options');
+        $delay = new xmldb_field('delay', XMLDB_TYPE_CHAR, '10', null, null, null, '0', 'duration');
+        if ($dbman->field_exists($optionstable, $delay)) {
+            $dbman->change_field_type($optionstable, $delay);
+        }
+
+        upgrade_mod_savepoint(true, 2024110807, 'contentdesigner');
+    }
+
     return true;
+
 }
diff --git a/version.php b/version.php
@@ -23,7 +23,7 @@
  */
 
 defined('MOODLE_INTERNAL') || die();
-$plugin->version   = 2024110806;    // The current module version (Date: YYYYMMDDXX).
+$plugin->version   = 2024110807;    // The current module version (Date: YYYYMMDDXX).
 $plugin->requires  = 2020061500;    // Requires this Moodle version.
 $plugin->component = 'mod_contentdesigner'; // Full name of the plugin (used for diagnostics).
 $plugin->release = 'v1.1';