Updated the ltool plugins capabilities

bdecentgmbh · Aug 30, 2021 · a8460f8 · a8460f8
1 parent 3883481
commit a8460f8
Show file tree

Hide file tree

Showing 16 changed files with 142 additions and 237 deletions.
diff --git a/amd/build/learningtools.min.js b/amd/build/learningtools.min.js
diff --git a/amd/build/learningtools.min.js.map b/amd/build/learningtools.min.js.map
diff --git a/amd/src/learningtools.js b/amd/src/learningtools.js
@@ -22,10 +22,15 @@
  */
 define([], function() {
 
-    function learning_tools_action(loggedin, fabbuttonhtml) {
+    /**
+     * Controls Learning Tools action.
+     * @param {bool} loggedin login status
+     * @param {object} fabbuttonhtml display fab button html.
+     */
+    function learningToolsAction(loggedin, fabbuttonhtml) {
         // Add fab button.
         if (loggedin) {
-            var pagewrapper = document.getElementById("page-footer");
+            var pagewrapper = document.querySelector("footer");
             pagewrapper.insertAdjacentHTML("beforebegin", fabbuttonhtml);
         }
 
@@ -43,7 +48,7 @@ define([], function() {
     }
     return {
         init: function(loggedin, fabbuttonhtml) {
-            learning_tools_action(loggedin, fabbuttonhtml);
+            learningToolsAction(loggedin, fabbuttonhtml);
         }
     };
 });
diff --git a/lib.php b/lib.php
@@ -389,7 +389,9 @@ function has_viewtool_capability_role($assignedroles, string $capability) {
 function get_instance_tool_view_url($row) {
     global $OUTPUT;
     $data = check_instanceof_block($row);
-
+    if (!isset($data->instance)) {
+        return '';
+    }
     if ($data->instance == 'course') {
         $courseurl = new moodle_url('/course/view.php', array('id' => $data->courseid));
         $viewurl = $OUTPUT->single_button($courseurl, get_string('viewcourse', 'local_learningtools'), 'get');

diff --git a/ltool/bookmarks/amd/build/learningbookmarks.min.js b/ltool/bookmarks/amd/build/learningbookmarks.min.js