Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error occurs Downloading OGIMet Stations for Luxembourg #93

Closed
BGWKlein opened this issue May 28, 2024 · 1 comment
Closed

Error occurs Downloading OGIMet Stations for Luxembourg #93

BGWKlein opened this issue May 28, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@BGWKlein
Copy link

When I try to download the OGIMET Stations of Luxembourg
climate::stations_ogimet(country = "Luxembourg")
an error occurs. The reason is that only one station is available in Luxembourg.

Possible solution for this problem:
https://github.com/bczernecki/climate/blob/master/R/stations_ogimet.R
line 90
res1 = res[, c(1, 3, 5:7), drop = FALSE]
instead of
res1 = res[, c(1, 3, 5:7)]

bczernecki added a commit that referenced this issue May 28, 2024
@bczernecki
Copy link
Owner

Thanks for the feedback! Indeed, for Luxembourg there's only 1 station and thus metadata are converted from matrix into vector. It is now addressed in #86 and should merged onto master branch soon

@bczernecki bczernecki self-assigned this May 28, 2024
@bczernecki bczernecki added the bug Something isn't working label May 28, 2024
bczernecki added a commit that referenced this issue Jun 18, 2024
* issue #80

* bug fixes for precip

* fix ogimet break between years

* update ogimet_daily

* fix ogimet_daily

* test pkgdown

* new pkgdown

* pkgdown pipeline

* turn on tests for metadata

* missing ogimet tests

* ogimet fix potential warning

* updates roxygen

* adding HALA GASIENICOWA IMGW metadata

* meteo_imgw_datastore

* draft finished

* meteo imgw telemetry

* fix: imgw telemetry

* imgw telemetry fix

* telemetry fix for empty files

* string as factors for old R version

* assertions for telemetry

* add globals to avoid NOTEs

* updates docs (#87)

* IMGW column encoding and telemetry support

* fix: HTML5

* fix: HTML5

* fix: HTML5

* climate 1.2.0

* fix: avoid warnings

* fix: run test only if network available

* replace R 3.6 with 4.0

* fix: #88 #85

* fix: rename telemetry stations

* fix: #93

* imgw station names extended

* add github actions for rhub

* doc fixes

* add stations_meteo_imgw_telemetry gently break

* add telemetry tests

* imgw telemetry tests

---------

Co-authored-by: Jakub Nowosad <tupiszakaczki@gmail.com>
Co-authored-by: Jakub Nowosad <Nowosad@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants