Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ogimet_hourly_bp issue for Africa #101

Closed
Nowosad opened this issue Nov 1, 2024 · 2 comments · Fixed by #100
Closed

ogimet_hourly_bp issue for Africa #101

Nowosad opened this issue Nov 1, 2024 · 2 comments · Fixed by #100
Assignees
Labels
bug Something isn't working

Comments

@Nowosad
Copy link
Collaborator

Nowosad commented Nov 1, 2024

HI, i'm tryimg t use climate package. so i want to download data from Mozambique station it is crushing and europe and america, but when i try to do the same for africa its crushing. I tried to 67341.

[100%] Downloaded 3306 bytes... | 25%
/tmp/Rtmp6KjyIu/file367439c7392d
Warning message:
In ogimet_hourly_bp(date = date, coords = coords, station = station, :
Wrong station ID: 67341 You can check station ID at https://ogimet.com/display_stations.php?lang=en&tipo=AND&isyn=&oaci=&nombre=&estado=&Send=Send

Originally posted by @hicardoso in #92 (comment)

@bczernecki bczernecki self-assigned this Nov 1, 2024
@Nowosad
Copy link
Collaborator Author

Nowosad commented Nov 1, 2024

@hicardoso -- I moved your problem into a new issue: it is generally better to add a new ones instead of writing on existing ones related to some other problems.

@bczernecki bczernecki added the bug Something isn't working label Nov 1, 2024
@bczernecki bczernecki linked a pull request Nov 1, 2024 that will close this issue
@bczernecki
Copy link
Owner

Thanks @hicardoso for the feedback.
I have just spotted wrong logic in the ogimet_hourly() function that may have impact in some cases.
I have just corrected that in a branch that is being prepared for upcoming release on CRAN, but you may also check it out by installing it from "99-hydro2023-fix" branch, i.e.

library(remotes)
install_github("bczernecki/climate@99-hydro2023-fix")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants