Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA: Include the subdir in tarball #1123

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Conversation

tleedjarv
Copy link
Contributor

Inspired by #1118, I think this was actually a bug in the original CI script, which was then also assumed by the _compat builds. This was very simple to change, so why not go for it.

@gdt
Copy link
Collaborator

gdt commented Feb 17, 2025

Is the idea that the SHA1 of the sources is in the tarball name? I think that's important to reduce confusion about which tarball is which later, and I'm pretty sure that's what you would intend. Looks like the commit is 46dbd65cdbcc60f68cfbb6798565cf3629bacabe. But an artifact is https://github.com/bcpierce00/unison/suites/34502718465/artifacts/2605140450 or at least that's the unhelpful link, and it downloads as unison-git_81cd90ca-ubuntu-x86_64.tar.gz___ocaml-4.14.x.ubuntu_compat-publish.zip with that hash inside. That looks like a commit hash, but I can't find it (I have your repo as a remote, so it's been fetched, and git log 46db shows me the commit).

@tleedjarv
Copy link
Contributor Author

That's right, the dir name is the same as tarball name (sans .tar.gz).

With an unmerged PR you get a different hash because GHA does a merge for the build (just look at the logs at the checkout step, for example: https://github.com/bcpierce00/unison/pull/1123/checks#step:3:61). This is completely unrelated to this PR.

@gdt
Copy link
Collaborator

gdt commented Feb 18, 2025

That's quite the GHA bug, making it hard to tie unmerged PR test artifacts back, but it's definitely not a bar to this fix.

@gdt gdt merged commit bd48168 into bcpierce00:master Feb 18, 2025
31 checks passed
@tleedjarv tleedjarv deleted the fix-1118 branch February 19, 2025 08:23
@tleedjarv
Copy link
Contributor Author

That's quite the GHA bug, making it hard to tie unmerged PR test artifacts back, but it's definitely not a bar to this fix.

I think there's a way around it (not sure why it's not the default). I'll try it out and open another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants