Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a comment about O_APPEND in openfile for Windows #1115

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Add a comment about O_APPEND in openfile for Windows #1115

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/system/system_win.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,11 @@ let rename f1 f2 =

let chown _ _ _ = raise (Unix.Unix_error (Unix.ENOSYS, "chown", ""))

(* TODO: O_APPEND in [Unix.openfile] for Windows was fixed in OCaml 5.3.
Remove the entire [openfile] definition below once the minimum supported
compiler version is >= 5.3.
Note: at the time of adding this comment, there is actually no code calling
[openfile] with O_APPEND. *)
let openfile f flags perm =
let fd = Unix.openfile f flags perm in
(* Comment from original C stub implementation:
Expand Down