From 9b11426a5e957c5bd04b66773f5c79b4346c79b1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?T=C3=B5ivo=20Leedj=C3=A4rv?= <toivol@gmail.com>
Date: Thu, 23 Jan 2025 20:33:29 +0100
Subject: [PATCH] Add a comment about O_APPEND in [openfile]

---
 src/system/system_win.ml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/system/system_win.ml b/src/system/system_win.ml
index 72b0061f6..5f7e6cbda 100644
--- a/src/system/system_win.ml
+++ b/src/system/system_win.ml
@@ -79,6 +79,11 @@ let rename f1 f2 =
 
 let chown _ _ _ = raise (Unix.Unix_error (Unix.ENOSYS, "chown", ""))
 
+(* TODO: O_APPEND in [Unix.openfile] for Windows was fixed in OCaml 5.3.
+   Remove the entire [openfile] definition below once the minimum supported
+   compiler version is >= 5.3.
+   Note: at the time of adding this comment, there is actually no code calling
+   [openfile] with O_APPEND. *)
 let openfile f flags perm =
   let fd = Unix.openfile f flags perm in
   (* Comment from original C stub implementation: