Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portable makefiles 6 #1096

Merged
merged 4 commits into from
Dec 16, 2024
Merged

Portable makefiles 6 #1096

merged 4 commits into from
Dec 16, 2024

Conversation

tleedjarv
Copy link
Contributor

No description provided.

There is no semantic change. The sole purpose of this patch is to make
the diff of following patches easier to read.
Some make implementations (OpenBSD make, NMAKE) do not support
target-specific local variables. This patch removes any local
variables that are used directly by the linking rules (as these
are now duplicated, local variables are no longer required).

The CAMLFLAGS variable is currently not removed (it is required for
compilation rules of the dependents) and will be handled separately
later on.
BSD make does not support mixing global and local variables. In other
words, do not use += to append to global variables in target-local
definitions.
Local variables must be defined for all targets directly because
BSD make does not propagate local variables to dependents.
@gdt gdt merged commit fbbc624 into bcpierce00:master Dec 16, 2024
31 checks passed
@tleedjarv tleedjarv deleted the portable-make-6 branch December 16, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants