Remove FAT-inspired DST workaround #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone pointed out to me that the time check is also used for update detection, and that this will mean that people syncing to/from FAT will have a full scan/hash every time the timezone changes (DST or a zone change). Of course, a subset of these cases (changes that aren't 1h) result in rescans now. |
gdt
force-pushed
the
remove-fat-dst-workaround
branch
from
8d79fee to
e855d52
Compare
|
I don't remember why this hasn't been merged alread, so I'm going to merge it in 24h. Overall I am increasingly unwilling to impose any negatives to accomodate platforms with problems, such as not having stable timestamps. |
|
My analysis is that the failing checks are CI infrastructure bugs, not problems in this PR. edit: Checks pass, after fix to CI. |
This was introduced in adf68c9 in 2009. The theory is that on Windows with FAT, filesystem times are in an undetermined timezone (a design defect) and as DST happens, the times of files already there change. While this is true, ignoring an hour change also ignores valid changes on filesystems that store times correctly (in UTC, as the major example). Ignoring an hour is not enough; if the host's timezone changes by 3 hours (or anything not 1), then times in FAT move by that amount. It's also too much, in that the workaround ignores time changes on filesystems with a stable time representation. Therefore, remove the workaround, and anyone who is using FAT, changing timezones, and syncing times (expected to be very few) can propose how to deal with this in a way that doesn't adversely affect others. Fixes bcpierce00#72.
gdt
force-pushed
the
remove-fat-dst-workaround
branch
from
e855d52 to
666144b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition, clean up related dead code.