Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using deprecated GdkPixbuf.from_xpm_data #1035

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Stop using deprecated GdkPixbuf.from_xpm_data #1035

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
941b19b
Stop using deprecated [GdkPixbuf.from_xpm_data]
tleedjarv May 7, 2024
6eddded
Fix dune build of the GTK GUI
tleedjarv May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/dune
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
(library
(name unison_lib)
(wrapped false)
(modules :standard \ linktext linkgtk3 uigtk3 uimacbridge test)
(modules :standard \ linktext linkgtk3 uigtk3 pixmaps uimacbridge test)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit message says "fix", but I think this is "add module that the previous commit started using". Always watching out for ways future self might misread....

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I considered it a fix as the list of modules was incorrect even before the pixbuf change. It's just that it didn't produce an actual error before the pixbuf change, but it wasn't correct. The pixbuf change made the Pixmaps module depend on lablgtk.

(modules_without_implementation ui)
(flags :standard
-w -3-6-9-10-26-27-32-34-35-38-39-50-52
Expand All @@ -27,5 +27,5 @@
(public_name unison-gui)
(package unison-gui) ; Dummy: we don't use packages
(flags :standard -w -3-6-9-27-32-52)
(modules linkgtk3 uigtk3)
(modules linkgtk3 uigtk3 pixmaps)
(libraries threads unison_lib lablgtk3))
Loading