Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: search bar in fav activity modal #1799

Merged
merged 17 commits into from
Jan 29, 2025

Conversation

xiaopeng0202
Copy link
Collaborator

@xiaopeng0202 xiaopeng0202 commented Jan 3, 2025

Description

Closes #1641

Changelog

New

  • add search bar in favourite activity modal

How was this tested?

  • 🧠 Not needed
  • 👀 Eyeball
  • 🤖 Added tests

What gif/image best describes this PR or how it makes you feel?


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@xiaopeng0202 xiaopeng0202 marked this pull request as draft January 3, 2025 18:25
Base automatically changed from feat/1637-add-favourite-modal to main January 21, 2025 18:36
@xiaopeng0202 xiaopeng0202 marked this pull request as ready for review January 21, 2025 19:12
@kevinginley
Copy link
Collaborator

Sorry @xiaopeng0202 , for some reason I'm not seeing where I can access the fav activity modal?

image
Am I missing something or looking at the wrong screen?

And I have a feeling this would be tricky to fix, but the favourite activity tooltip is cut off by the navigation panel:
Screenshot (416)

@xiaopeng0202
Copy link
Collaborator Author

Sorry @xiaopeng0202 , for some reason I'm not seeing where I can access the fav activity modal?

image Am I missing something or looking at the wrong screen?

And I have a feeling this would be tricky to fix, but the favourite activity tooltip is cut off by the navigation panel: Screenshot (416)

oh, sorry, it's invisible from the nav bar, just try this link

https://nr-spar-49-frontend.apps.silver.devops.gov.bc.ca/consep/favourite-activities

@kevinginley
Copy link
Collaborator

@xiaopeng0202 Thanks! I can access it now.

For the heading:
You don't have any favorites to show yet!

please change to:
You don't have any favourites to show yet!

(adding a "u" to "favorite")

Similarly, please update the text below to read:

You can favourite your activities by clicking on "Add favourite activity" or by clicking on the heart icon on each page.


For the "My favourite activities" page - currently, only one favourite can be highlighted at any given time. Is that the intended behavior?


The add favourite activity modal looks great and search bar is working for me.

@xiaopeng0202
Copy link
Collaborator Author

@xiaopeng0202 Thanks! I can access it now.

For the heading: You don't have any favorites to show yet!

please change to: You don't have any favourites to show yet!

(adding a "u" to "favorite")

Similarly, please update the text below to read:

You can favourite your activities by clicking on "Add favourite activity" or by clicking on the heart icon on each page.

For the "My favourite activities" page - currently, only one favourite can be highlighted at any given time. Is that the intended behavior?

The add favourite activity modal looks great and search bar is working for me.

Updated. Oh for the highlighted part, we'd like to support multiple highlight? Could that be as many as 12?

@kevinginley
Copy link
Collaborator

Updated. Oh for the highlighted part, we'd like to support multiple highlight? Could that be as many as 12?

Yes, that sounds good to me - being able to highlight multiple favourite activities with a maximum of 12

@xiaopeng0202
Copy link
Collaborator Author

Updated. Oh for the highlighted part, we'd like to support multiple highlight? Could that be as many as 12?

Yes, that sounds good to me - being able to highlight multiple favourite activities with a maximum of 12

sounds good, i will have a follow up PR

Copy link
Collaborator

@mgaseta mgaseta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!
Added a few comments and suggestions.

Copy link
Collaborator

@mgaseta mgaseta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Nice job!

@xiaopeng0202 xiaopeng0202 merged commit bcf669f into main Jan 29, 2025
28 of 29 checks passed
@xiaopeng0202 xiaopeng0202 deleted the feat/1641-search-in-add-fav-modal branch January 29, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

search functionality for "add favourites modal"
3 participants