chore: reconfigured trigger conditions for precommit action #128
Conversation
BallardRobinett
requested review from
mikevespi,
joshgamache,
pbastia and
JoshLarouche
| @@ -2,11 +2,8 @@ name: Precommit tests | |||
|
|
|||
| on: | |||
| push: | |||
| branches: | |||
| - '*' | |||
| branches: [main, develop] | |||
| pull_request: | |||
There was a problem hiding this comment.
you'll want PR only on main and develop too (at least that's how it's setup everywhere else)
| pull_request: | ||
| branches: | ||
| - '*' | ||
|
|
||
| jobs: | ||
| pre-commit: |
There was a problem hiding this comment.
We need to remove the dependency on install_dev_tools or import that job too if it's necessary
BallardRobinett
force-pushed
the
127-fix-precommit-conditions
branch
from
eddddb7 to
767568f
Compare
| using: composite | ||
| steps: | ||
| - name: asdf setup | ||
| uses: asdf-vm/actions/setup@v1 |
There was a problem hiding this comment.
| uses: asdf-vm/actions/setup@v1 | |
| uses: asdf-vm/actions/setup@v3 |
| steps: | ||
| - name: asdf setup | ||
| uses: asdf-vm/actions/setup@v1 | ||
| - uses: actions/cache@v3 |
There was a problem hiding this comment.
| - uses: actions/cache@v3 | |
| - uses: actions/cache@v4 |
| with: | ||
| path: | | ||
| ~/.asdf | ||
| ./bc_obps/.tool-versions |
There was a problem hiding this comment.
Once you rebase:
| ./bc_obps/.tool-versions | |
| ./server/.tool-versions |
| key: ${{ runner.os }}-yarn-cache-${{ hashFiles('client/yarn.lock') }}-v2 | ||
| - name: Set up python | ||
| id: setup-python | ||
| uses: actions/setup-python@v4 |
There was a problem hiding this comment.
| uses: actions/setup-python@v4 | |
| uses: actions/setup-python@v5 |
| id: setup-python | ||
| uses: actions/setup-python@v4 | ||
| with: | ||
| python-version: "3.9.16" |
There was a problem hiding this comment.
Probably enough to specify the minor to make sure we get the updates without work on our end
| python-version: "3.9.16" | |
| python-version: "3.9" |
.github/workflows/eslint.yaml
Outdated
| with: | ||
| node-version: 20 | ||
| - name: Install dependencies | ||
| run: yarn install |
There was a problem hiding this comment.
I wonder if there's a lot of value in running eslint over the entire repository, we might be better off scoping this to the client directory (and this way we avoid installing packages at the root of the project)
.github/workflows/precommit.yaml
Outdated
| @@ -2,35 +2,14 @@ name: Precommit tests | |||
|
|
|||
| on: | |||
| push: | |||
| branches: | |||
| - '*' | |||
| branches: [main, develop, 127-fix-precommit-conditions] | |||
There was a problem hiding this comment.
| branches: [main, develop, 127-fix-precommit-conditions] | |
| branches: [main, develop] |
.github/workflows/precommit.yaml
Outdated
| ./.pre-commit-cache | ||
| key: pre-commit-${{ env.PY }}-${{ hashFiles('.pre-commit-config.yaml') }}-v3 | ||
| - run: pre-commit run --all-files | ||
| - uses: actions/setup-python@v3 |
There was a problem hiding this comment.
| - uses: actions/setup-python@v3 | |
| - uses: actions/setup-python@v5 |
This also needs a version for python
package.json
Outdated
| "@typescript-eslint/eslint-plugin": "^6.21.0", | ||
| "@typescript-eslint/parser": "^6.21.0", |
There was a problem hiding this comment.
These would likely be better housed in the package.json in the client folder
package.json
Outdated
| "dependencies": { | ||
| "eslint": "^8.56.0", | ||
| "pre-commit": "^1.2.2", | ||
| "typescript": "^5.3.3" | ||
| } |
There was a problem hiding this comment.
There aren't any dependencies that need to be shipped in this package either, I don't think these are needed here
BallardRobinett
force-pushed
the
127-fix-precommit-conditions
branch
2 times, most recently
from
54898f8 to
767568f
Compare
Issue: #127
Reconfigured the trigger conditions for precommit. It should be on push for main and develop, and on PR to any branch.
To test: create a PR and see if precommit runs.